This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-29399] Remove an unused changeCSS() style #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA review will be done when merging the branch into Master. |
hmhealey
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Good catch that that rule isn't actually used. It looks like it's being overwritten by the .app__body .modal .settings-modal .nav-pills>li.active button:active rule on like 539 of utils.jsx. The git blame looks like that's been the case for a few years now, so I think it's safe just to remove instead of potentially treating that as a bug
nevyangelova
approved these changes
Oct 9, 2020
deanwhillier
added a commit
that referenced
this pull request
Oct 16, 2020
* Remove an unused changeCSS() style (#6680) Fixes mattermost/mattermost#15837 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399 * [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695) Fixes mattermost/mattermost#15831 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392 * [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686) Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515 Fixes mattermost/mattermost#15836 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397 * [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692) Remove the line as it isn't possible that .sidebar__switcher button contains a svg Fixes mattermost/mattermost#15835 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396 * [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696) Fixes mattermost/mattermost#15830 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391 * [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694) Fixes mattermost/mattermost#15832 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393 * [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693) Fixes mattermost/mattermost#15833 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394 Co-authored-by: Dean Whillier <[email protected]> * Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697) * [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828) This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS Fixes mattermost/mattermost#15828 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389 * [MM-29390] Remove references to removed perfect-scrollbar component (#15829) While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used It turns out it was an old dependency removed by PR #4382 This commit removes remaining references Fixes mattermost/mattermost#15829 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390 Co-authored-by: Nicolas Le Cam <[email protected]> Co-authored-by: Mattermod <[email protected]>
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* Remove an unused changeCSS() style (#6680) Fixes mattermost/mattermost#15837 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399 * [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695) Fixes mattermost/mattermost#15831 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392 * [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686) Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515 Fixes mattermost/mattermost#15836 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397 * [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692) Remove the line as it isn't possible that .sidebar__switcher button contains a svg Fixes mattermost/mattermost#15835 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396 * [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696) Fixes mattermost/mattermost#15830 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391 * [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694) Fixes mattermost/mattermost#15832 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393 * [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693) Fixes mattermost/mattermost#15833 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394 Co-authored-by: Dean Whillier <[email protected]> * Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697) * [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828) This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS Fixes mattermost/mattermost#15828 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389 * [MM-29390] Remove references to removed perfect-scrollbar component (#15829) While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used It turns out it was an old dependency removed by PR #4382 This commit removes remaining references Fixes mattermost/mattermost#15829 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390 Co-authored-by: Nicolas Le Cam <[email protected]> Co-authored-by: Mattermod <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Remove an unused changeCSS() style (#6680) Fixes mattermost/mattermost#15837 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399 * [MM-29392] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 516 (#15831) (#6695) Fixes mattermost/mattermost#15831 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29392 * [MM-29397] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln 525 (#15836) (#6686) Remove the line as style is already applied unconditionally and more broadly by changeCss() call at line 515 Fixes mattermost/mattermost#15836 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29397 * [MM-29396] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 523 (#15835) (#6692) Remove the line as it isn't possible that .sidebar__switcher button contains a svg Fixes mattermost/mattermost#15835 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29396 * [MM-29391] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 513 (#15830) (#6696) Fixes mattermost/mattermost#15830 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29391 * [MM-29393] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 519 (#15832) (#6694) Fixes mattermost/mattermost#15832 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29393 * [MM-29394] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 520 (#15833) (#6693) Fixes mattermost/mattermost#15833 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29394 Co-authored-by: Dean Whillier <[email protected]> * Migrate changeCSS(sideText) to CSS variable --sidebartext in utils/utils.jsx (#6697) * [MM-29389] Migrate changeCSS() to CSS variable in utils/utils.jsx, ln. 510 (#15828) This line was unconditionally replaced by line 824 using --link-color so I directly used --link-color in CSS Fixes mattermost/mattermost#15828 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29389 * [MM-29390] Remove references to removed perfect-scrollbar component (#15829) While analyzing mattermost/mattermost#15829 I couldn't found where ps-container class was used It turns out it was an old dependency removed by PR #4382 This commit removes remaining references Fixes mattermost/mattermost#15829 JIRA ticket: https://mattermost.atlassian.net/browse/MM-29390 Co-authored-by: Nicolas Le Cam <[email protected]> Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove an unused changeCSS() style
Ticket Link
Fixes mattermost/mattermost#15837
JIRA ticket: https://mattermost.atlassian.net/browse/MM-29399