Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Added additional cypress tests part of MM-29347 #6654

Merged
merged 6 commits into from
Oct 20, 2020
Merged

Added additional cypress tests part of MM-29347 #6654

merged 6 commits into from
Oct 20, 2020

Conversation

srkgupta
Copy link
Contributor

@srkgupta srkgupta commented Oct 6, 2020

Summary

MM-29347: E2E Cypress Tests - System Console > Enterprise > Group Mentions (Part 2)

Ticket Link

JIRA Ticket:
MM-29347

TM4J Tests:
MM-T2447
MM-T2460
MM-T2461

Related Pull Requests

None

Screenshots

Screenshot 2020-10-06 at 7 35 45 PM

@srkgupta srkgupta added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 6, 2020
Copy link
Contributor

@hahmadia hahmadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks very clean and nicely documented. I like! 👍

@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label Oct 6, 2020
@srkgupta
Copy link
Contributor Author

/update-branch

@srkgupta
Copy link
Contributor Author

The last commit was actually a fix based on the PR 6652

@srkgupta
Copy link
Contributor Author

/update-branch

Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srkgupta I haven't run the test because my local server has not run normally today. But I gave it a thorough look, and it looks great! Also checked
Approving.
Also a quick note that the associated Jira ticket has more tests than are covered in this PR, not sure what the state of the other tests are, so I haven't closed that one.

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 20, 2020
@prapti prapti merged commit f62c757 into mattermost:master Oct 20, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 20, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* Added additional cypress tests part of MM-29347

* Fixed issue on fresh LDAP setup

* Added additional timeouts after cy.visit

* Fixed comments from PR 6773

Co-authored-by: Mattermod <[email protected]>
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* Added additional cypress tests part of MM-29347

* Fixed issue on fresh LDAP setup

* Added additional timeouts after cy.visit

* Fixed comments from PR 6773

Co-authored-by: Mattermod <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants