This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-29347: E2E Cypress Tests - System Console > Enterprise > Group Mentions (Part 1) #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephbaylon
approved these changes
Oct 7, 2020
josephbaylon
suggested changes
Oct 7, 2020
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Outdated
Show resolved
Hide resolved
josephbaylon
suggested changes
Oct 7, 2020
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Show resolved
Hide resolved
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Outdated
Show resolved
Hide resolved
|
Thanks @josephbaylon. Addressed your comments and added additional timeouts after cy.visit. Please recheck. |
josephbaylon
approved these changes
Oct 7, 2020
saturninoabril
suggested changes
Oct 8, 2020
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Outdated
Show resolved
Hide resolved
e2e/cypress/integration/enterprise/group_mentions/group_mentions_system_messages_spec.js
Outdated
Show resolved
Hide resolved
|
/update-branch |
|
Thanks @saturninoabril for your feedback. Committed the requested changes. Please recheck. Thanks. |
saturninoabril
approved these changes
Oct 14, 2020
saturninoabril
added
4: Reviews Complete
|
Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour. |
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
…tions (Part 1) (#6652) * Added some cypress tests part of MM-29347 * Fixed issue on fresh LDAP setup * Added additional timeouts after cy.visit * Fixed as per PR review comments Co-authored-by: Mattermod <[email protected]>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
…tions (Part 1) (#6652) * Added some cypress tests part of MM-29347 * Fixed issue on fresh LDAP setup * Added additional timeouts after cy.visit * Fixed as per PR review comments Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-29347: E2E Cypress Tests - System Console > Enterprise > Group Mentions (Part 1)
Ticket Link
JIRA Ticket:
MM-29347
TM4J Tests:
MM-T2456
MM-T2457
MM-T2458
MM-T2459
Related Pull Requests
None
Screenshots