This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-T555 Notification Preferences do not save when modal is closed without saving #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
added
2: Dev Review
josephbaylon
suggested changes
Sep 1, 2020
There was a problem hiding this comment.
Hi @josephk96 I'm getting this error consistently locally. Please check.
saturninoabril
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Thanks @josephk96! Tested and passed. LGTM.
@josephbaylon The one you're seeing is valid bug with fix #6355
|
/update-branch |
josephbaylon
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
LGTM. Test passed locally with the latest. Thanks @josephk96 !!
josephbaylon
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This test clicks on Account Settings -> Notifications -> Email Notifications -> Send Email Notifications -> Never without saving, closes the Account Settings Modal, reopens it, and verifies that the setting was not saved.
Test case: https://automation-test-cases.vercel.app/test/MM-T555