Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28230] Add defaultProps to user_settings_modal for new onExit prop #6355

Merged
merged 2 commits into from
Sep 2, 2020
Merged

[MM-28230] Add defaultProps to user_settings_modal for new onExit prop #6355

merged 2 commits into from
Sep 2, 2020

Conversation

nickmisasi
Copy link
Contributor

Summary

A defaultProps was missed that left this component somewhat broken on certain entry-points. Added a noop function for if it's not passed.

Main Menu > Account Settings
Close Account Settings
Webapp should continue working as before

Ticket Link

https://mattermost.atlassian.net/browse/MM-28230

Related Pull Requests

  • Has server changes n/a
  • Has redux changes n/a
  • Has mobile changes n/a

Screenshots

n/a

@nickmisasi nickmisasi added 2: Dev Review Requires review by a core commiter Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 2, 2020
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 2, 2020
@nickmisasi nickmisasi added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 2, 2020
saturninoabril
saturninoabril approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickmisasi. Tested and passed.

@nickmisasi nickmisasi added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter QA Review Done Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 2, 2020
@devinbinnie devinbinnie added 2: Dev Review Requires review by a core commiter QA Review Done Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed 4: Reviews Complete All reviewers have approved the pull request labels Sep 2, 2020
gabrieljackson
gabrieljackson approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter QA Review Done Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 2, 2020
@mm-cloud-bot
Copy link

Test server destroyed

@nickmisasi nickmisasi merged commit c2d07c5 into master Sep 2, 2020
@nickmisasi nickmisasi deleted the MM-28230 branch September 2, 2020 14:39
@nickmisasi nickmisasi self-assigned this Sep 2, 2020
@amyblais amyblais added the Changelog/Not Needed Does not require a changelog entry label Sep 6, 2020
@amyblais amyblais added the Docs/Not Needed Does not require documentation label Sep 6, 2020
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@nickmisasi @jfrerich
[MM-28230] Add defaultProps to user_settings_modal for new onExit prop (
a685f95 
#6355)

* Add defaultProps to user_settings_modal

* Fix pipeline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrieljackson gabrieljackson gabrieljackson approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@nickmisasi nickmisasi

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickmisasi @mm-cloud-bot @gabrieljackson @saturninoabril @devinbinnie @amyblais