MM-22155 Disable no-magic-numbers

.eslintrc.json

@@ -38,19 +38,6 @@
  ]
  }
  ],
- "no-magic-numbers": [
- 1,
- {
- "ignore": [
- -1,
- 0,
- 1,
- 2
- ],
- "enforceConst": true,
- "detectObjects": true
- }
- ],
  "no-undefined": 0,
  "react/jsx-filename-extension": 0,
  "react/prop-types": [

components/searchable_user_list/searchable_user_list.jsx

@@ -42,7 +42,7 @@ class SearchableUserList extends React.Component {
 
  static defaultProps = {
  users: [],
- usersPerPage: 50, // eslint-disable-line no-magic-numbers
+ usersPerPage: 50,
  extraInfo: {},
  actions: [],
  actionProps: {},

e2e/cypress/integration/accessibility/accessibility_popovers_spec.js

@@ -61,8 +61,8 @@ describe('Verify Accessibility Support in Popovers', () => {
  });
 
  // * Verify emoji navigation using arrow keys
- verifyArrowKeysEmojiNavigation('{rightarrow}', 3); // eslint-disable-line no-magic-numbers
- verifyArrowKeysEmojiNavigation('{leftarrow}', 2); // eslint-disable-line no-magic-numbers
+ verifyArrowKeysEmojiNavigation('{rightarrow}', 3);
+ verifyArrowKeysEmojiNavigation('{leftarrow}', 2);
 
  // # Press tab
  cy.get($el).focus().tab();

e2e/cypress/integration/emoji/react_to_last_message_shortcut_spec.js

@@ -44,7 +44,6 @@ describe('Keyboard shortcut for adding reactions to last message in channel or t
 
  // # Create a new channel for later use such as when channel is empty test
  cy.getCurrentTeamId().then((teamId) => {
- // eslint-disable-next-line no-magic-numbers
  cy.apiCreateChannel(teamId, newChannelName, newChannelName).then((response) => {
  testChannel = response.body;
  });

utils/constants.jsx

@@ -1,7 +1,6 @@
 // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
 // See LICENSE.txt for license information.
 
-/* eslint-disable no-magic-numbers */
 import keyMirror from 'key-mirror';
 
 import Permissions from 'mattermost-redux/constants/permissions';