This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-22155 ESLint configuration updates part 1 #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2020
devinbinnie
approved these changes
May 20, 2020
| @@ -68,7 +68,7 @@ describe('Paste.formatGithubCodePaste', () => { | |||
| const message = "```\n// a javascript codeblock example\nif (1 > 0) {\n return 'condition is true';\n}\n```"; | |||
| const codeBlock = "```\n// a javascript codeblock example\nif (1 > 0) {\n return 'condition is true';\n}\n```"; | |||
|
|
|||
| const {formattedMessage, formattedCodeBlock} = formatGithubCodePaste(0, '', clipboardData); | |||
| const {formattedMessage, formattedCodeBlock} = formatGithubCodePaste(0, '', clipboardData); // eslint-disable-line @typescript-eslint/no-unused-vars | |||
There was a problem hiding this comment.
I filed a ticket to fix these. The tests weren't written correctly, so I added the ignore comments so that the argument handling doesn't need to be re-added when the tests are fixed.
There was a problem hiding this comment.
Once #5559 is merged, these can be removed. I'll do that in this PR if that one makes it in first.
nevyangelova
approved these changes
May 25, 2020
hmhealey
added
4: Reviews Complete
|
Skipping dev review since these are only code style changes |
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the configuration changes proposed here. It's focused on the simpler things to change like allowing
undefinedsince it's better supported in TypeScript, getting rid of a few annoying warnings (file extensions and magic numbers), and re-enabling some stuff that was disabled during the TypeScript migration (camelcase naming, nested ternaries, and unused variables).The biggest change in this one is that re-enabling the
no-unused-varscheck requires a bunch of redux action creators to have their return type changed, although this is consistent with what we had in the past.Most of the rules changes in the
.eslintrc.jsonwill be moved to our ESLint plugin later once all the repos are consistent.Ticket Link
https://mattermost.atlassian.net/browse/MM-22155
Related Pull Requests
mattermost/mattermost-mobile#4311
mattermost/mattermost-redux#1158