Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-21255 - Search "in:@username" changes the label to "in:userid" in the search input #4792

Merged
merged 1 commit into from
Jan 31, 2020
Merged

MM-21255 - Search "in:@username" changes the label to "in:userid" in the search input #4792

merged 1 commit into from
Jan 31, 2020

Conversation

reflog
Copy link
Contributor

@reflog reflog commented Jan 30, 2020

Summary

There was a bug introduced in #4217 regarding passing the selected result back to searchbox

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-21255

@reflog reflog added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 30, 2020
@amyblais amyblais added this to the v5.20.0 milestone Jan 30, 2020
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Jan 30, 2020
@lindy65 lindy65 added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 31, 2020
lindy65
lindy65 approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@lindy65 lindy65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reflog - this is fixed. the label remains in:@username in the Search input box. 👍

@lindy65 lindy65 added QA Review Done and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Jan 31, 2020
@mattermod
Copy link
Contributor

Test server destroyed

@Willyfrog Willyfrog added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jan 31, 2020
@Willyfrog Willyfrog merged commit c8e091b into mattermost:master Jan 31, 2020
@mattermost-build mattermost-build mentioned this pull request Jan 31, 2020
Merged
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 31, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@lindy65 lindy65 lindy65 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
Milestone
v5.20.0
6 participants
@reflog @mattermod @Willyfrog @asaadmahmood @lindy65 @amyblais