MM-18911: Filtering search by channel should also show the channel name and not only its ID

[allenl7]

Summary

Web app filter search in: to display channel name (channel id) and display name like mobile

https://user-images.githubusercontent.com/7275313/68829461-d300ed80-065d-11ea-9642-2fbfdadbf6a2.PNG

Ticket Link

( https://mattermost.atlassian.net/browse/MM-18911 )

Screenshots

[Willyfrog]

this should only change the suggestion for channel autocompletion, so the user can identify a channel by either its id or its name, depending on what's familiar for him. With the proposed change it is adding extra info to the search and nothing can be found.

Let me know if you need any more details on the approach

[esethna]

1. The test server shows a different character, it should be the tilde as displayed here: ~
2. The tilde should be within the parentheses (~some-channel)

Other than that looks good, adding Katie as this touches her area

[allenl7]

1. The test server shows a different character, it should be the tilde as displayed here: ~
2. The tilde should be within the parentheses (~some-channel)

Other than that looks good, adding Katie as this touches her area

Moved the tilde inside the parentheses. @esethna do you think it looks like a '-' because of the browser? it a tilde on mine.

[esethna]

@allenlai18, hmm you're correct I believe, the tilde looks like that in channel autocomplete as well however we should look into fixing that if possible, but not blocking this PR. Approving this PR.

[Willyfrog]

@allenlai18 this prevents searching, it should display as you did, but search functionality shouldn't break because of this change.

[allenl7]

@allenlai18 this prevents searching, it should display as you did, but search functionality shouldn't break because of this change.

I see what you're saying now. the search is breaking when you search in a channel. i will look into this

[wiersgallak]

I am seeing a tilde in my testing on Mac and it is correctly placed inside of the parentheses.

I have added another channel "Katie Test (~apple). The channel name is not being identified by autocomplete in a search starting with "t"

[allenl7]

I am seeing a tilde in my testing on Mac and it is correctly placed inside of the parentheses.

I have added another channel "Katie Test (~apple). The channel name is not being identified by autocomplete in a search starting with "t"

I think that is the expected behavior. katieTest is camel cased. if it was seperated with dashes it works. what @Willyfrog was talking about is the search is broken when you search for posts within a channel.

[allenl7]

@allenlai18 this prevents searching, it should display as you did, but search functionality shouldn't break because of this change.

Fixed! Let me know what you think.

[mattermod]

Mattermost test server updated with git commit 956e0a538134e37f7b56b02f033e0178812b2717.

Access here: https://mattermost-webapp-pr-4217.test.mattermost.cloud

[Willyfrog]

LGTM! thanks for your contribution!

[wiersgallak]

Looks good to me now. Confirmed searching is working as expected in channel as well. Thanks for clarifying the behavior on the camel case, this may be something we will want to address but can do outside of this PR.

[hmhealey]

Looks good to me!

[jgilliam17]

Tested, looks good to merge

[mattermod]

Test server destroyed

[allenl7]

@Willyfrog can you merge when you get a chance?