This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8321: simplify isXVisible callsites #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
approved these changes
Dec 7, 2017
jwilander
approved these changes
Dec 8, 2017
saturninoabril
pushed a commit
that referenced
this pull request
Dec 14, 2017
* Migrate create_post component to redux Remove channelId and channel from state as it is avaialable via props. Remove Team store dependency. Remove User store dependency Remove Preferences store dependency. * Remove preferences from store as props change trigger render. * Add selector for preferences Move REACTION_PATTERN to utils. Remove message_history_store dependency. Add redux post actions instead of flux actions. Change bind functions to class prop arrow functions. Add proptype comments. Remove couple of unused variables. * Remove all bind functions. * Add MESSAGE_TYPES constants. Remove few postStore dependent functions. Add getCurrentUsersLatestPostId redux state selector. Add Test cases for create_post Remove uploadInprogress and filesInfo from state Remove unused variable from file_preview which causes mutation on props. Fix sort on filesInfo for file_preview component. Fix draft constant Remove postStore dependecy. Add edit dispatch from redux. Add test cases Fix failing snapshots. * Fix review comments * Fix member count in render for notifying user on @ALL * Fix test cases Change currentChannelMembersCount default value to 1 as user is part of the channel. * Fix for the value getCurrentChannelStats as on team creation and thread creation it is undefined. * Adds inline make documentation and 'help' command. (#394) * Fix atmention to check for user on users object only (#419) * PLT-8237 - Updating modal textarea overflow (#414) * [PLT-6940] Add webrtc call at channel navbar and make it available on narrow window (#17) * add webrtc call at channel navbar and make it available on narrow window * rebase * updated and add unit tests * update snapshot * [PLT-8222] Add 100% height to root and fix setState warning on ManageLanguage component (#409) * add 100% height to root and fix setState warning on ManageLanguage component * update #root class and move other logics of LoggedIn to componentDidMount * remove setState call on success updateUser * add channelId to RECEIVED_POSTS action after edit (#424) * Add deactivated users to dm modal (#401) * add deactivated users to dm modal * address pr comments * Create NOTICE.txt (#376) * Create NOTICE.txt * Changed react to react-dom * Update mattermost-redux to 1.1.0 (#417) * Use CMD instead of CTRL for textbox focusing on Mac (#407) * PLT-8236 Properly highlight at mentions for the current user which are followed by punctuation (#405) * Reset post viewed count when switching channels (#373) * Upgrade WebRTC client driver (#383) * PLT-8170: Fix channel name / purpose modals (#416) * fix channel name / purpose modals * update snapshots * another snapshot update * Fixing LDAP nickname setting block. (#403) * Remove hard-coded link to System Console stats docs (#393) * Update system_analytics.jsx * Update en.json * Note that desktop notification duration is a max of 5 seconds for desktop apps (#362) * Update desktop_notification_settings.jsx * Update en.json * Add Config to disable Auth Transfers. Remove frontend switch to email and password. (#328) * remove the video call from the his own DM channel (#411) * Backward compatible fix theme.mentionBg typo (#322) * Backward compatible fix theme.mentionBg typo * Save mentionBj with mentionBg * Fix styling * PLT-8292 - Updating webrtc button (#415) * PLT-8292 - Updating webrtc button * Updating webrtc conditional * Add pluggable component in mobile channel header (#412) * Add pluggable component in mobile channel header * Fix styling * Update snapshot * Fix mobile view search button (#408) * unit tests for AccessHistoryModal and ActivityLogModal (#413) * remove unused type arg of UserActions.updateUser and remove unused/unnecessary Constants.UserUpdateEvents (#410) * Create comment use the component state to show/edit the draft (#395) * translations PR 20171204 (#402) * Hide locale setting if there's a single locale available (#330) * UCHAT-275 Add config option to hide locale setting * Hide locale setting if there's a single locale available Ex: AvailableLocales: en * PLT-8321: simplify isXVisible callsites (#428) * simplify isXVisible callsites * update package.json * PLT-8198: System Console updates for message/compliance export (#390) * Updated the text on the System Console settings page to approved copy * Language fixes from the PR * More text updates * Removed export location setting from the UI * Fixed style * Fixed bug preventing user from enabling/disabling compliance export * PLT-8198: System Console updates for message/compliance export (#390) * Updated the text on the System Console settings page to approved copy * Language fixes from the PR * More text updates * Removed export location setting from the UI * Fixed style * Fixed bug preventing user from enabling/disabling compliance export (cherry picked from commit a9107f3) * Update NOTICE.txt (#426) * Avoid creating a new EmojiMap for each post (#431) * Avoid creating a new EmojiMap for each post * Removed debug message * fix js error in dm add user modal (#437) * Allow deactivation of SSO users (#423) * Update jenkinsfile (#444) * add test to AccountSettingsDisplay modal (#440) * change inline arrow function in ref (#449) * Fix jenkinsfile s3 push (#452) * Fix typo in audit table component (#427) * Fix typo in audit table component * Updating i18n strings as well, as requested * Added PostMarkdown component (#404) * Added PostMarkdown component * Fixed failing tests * Fixing styles * add unit test to AddUsersToTeam and fix function/unused codes (#420) * Remove div container taking up width (#425) this blocks users from clicking messages directly behind the NewMessageIndicator compnent * Fix mutation on draft file remove * Migrate do_verify_email to Redux (#338) * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display * Code Review Fixes * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** * Fix Tests * Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display * Code Review Fixes * WIP: Changes to testing Work in Progress, last two tests returning errors. * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display Code Review Fixes Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** WIP: Changes to testing Work in Progress, last two tests returning errors. Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display WIP: Changes to testing Work in Progress, last two tests returning errors. Code Review Fixes Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 Fixed test errors Fix test name Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 * Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display Code Review Fixes Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** WIP: Changes to testing Work in Progress, last two tests returning errors. Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display Code Review Fixes Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** WIP: Changes to testing Work in Progress, last two tests returning errors. Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Migrate do_verify_email to Redux **Should wait until enzyme & react version issues are resolved** Fix Tests Finalized component tests * Snapshot test * verifyEmail function test * Test mattermost-redux action & error display WIP: Changes to testing Work in Progress, last two tests returning errors. Code Review Fixes Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 Fixed test errors Fix test name Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 Remove useless Adapter import in test Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784 * Fix merge issue * Migrate create_post component to redux Remove channelId and channel from state as it is avaialable via props. Remove Team store dependency. Remove User store dependency Remove Preferences store dependency. * Remove preferences from store as props change trigger render. * Add selector for preferences Move REACTION_PATTERN to utils. Remove message_history_store dependency. Add redux post actions instead of flux actions. Change bind functions to class prop arrow functions. Add proptype comments. Remove couple of unused variables. * Remove all bind functions. * Add MESSAGE_TYPES constants. Remove few postStore dependent functions. Add getCurrentUsersLatestPostId redux state selector. Add Test cases for create_post Remove uploadInprogress and filesInfo from state Remove unused variable from file_preview which causes mutation on props. Fix sort on filesInfo for file_preview component. Fix draft constant Remove postStore dependecy. Add edit dispatch from redux. Add test cases Fix failing snapshots. * Fix review comments * Fix member count in render for notifying user on @ALL * Fix test cases Change currentChannelMembersCount default value to 1 as user is part of the channel. * Fix for the value getCurrentChannelStats as on team creation and thread creation it is undefined. * Fix mutation on draft file remove
hmhealey
added a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
added a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update for mattermost/mattermost-redux#351
Once that PR is merged, I'll need to update package.json here before building / merging this.
Ticket Link
https://mattermost.atlassian.net/browse/PLT-8321
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed