Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Add Config to disable Auth Transfers. Remove frontend switch to email… #328

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Add Config to disable Auth Transfers. Remove frontend switch to email… #328

merged 1 commit into from
Dec 7, 2017

Conversation

csduarte
Copy link
Contributor

Summary

Enables/Disables the ability to perform an auth transfer for a user based on the server config setting for EnableAuthenticationTransfer.

server pr: mattermost/mattermost#7843

cc @dmeza

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@jasonblais jasonblais added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Nov 20, 2017
@jasonblais jasonblais self-requested a review November 20, 2017 22:03
@jasonblais jasonblais self-assigned this Nov 20, 2017
@jasonblais jasonblais added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed Setup Old Test Server Triggers the creation of a test server labels Nov 20, 2017
@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Setup Old Test Server Triggers the creation of a test server labels Nov 29, 2017
@mattermost mattermost deleted a comment from mattermod Nov 29, 2017
@mattermost mattermost deleted a comment from mattermod Nov 29, 2017
@mattermost mattermost deleted a comment from mattermod Nov 29, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Nov 29, 2017
@dmeza dmeza force-pushed the bash-11_disable-auth-transfer branch from c2431aa to 99e5a87 Compare November 30, 2017 04:23
@dmeza
Copy link
Contributor

dmeza commented Nov 30, 2017

@jasonblais rebased to latest from master and refactored config name from EnableAuthenticationTransfer to ExperimentalEnableAuthenticationTransfer to match the server side change.

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Nov 30, 2017
@mattermost mattermost deleted a comment from mattermod Nov 30, 2017
@mattermost mattermost deleted a comment from mattermod Nov 30, 2017
@mattermost mattermost deleted a comment from mattermod Nov 30, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Nov 30, 2017
@lindalumitchell
Copy link
Contributor

JW helped flip the setting, and I verified that the option is not visible in Account Settings > Security to change signin method, for admin or non-admin. Also double-checked user can still successfully change password in Account Settings > Security.

@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Dec 5, 2017
@jasonblais jasonblais removed their assignment Dec 5, 2017
@mattermost mattermost deleted a comment from mattermod Dec 5, 2017
@mattermost mattermost deleted a comment from mattermod Dec 5, 2017
@mattermost mattermost deleted a comment from mattermod Dec 5, 2017
@jasonblais jasonblais added this to the v4.5.0 milestone Dec 5, 2017
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 7, 2017
@jwilander jwilander merged commit 7552201 into mattermost:master Dec 7, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Dec 7, 2017
saturninoabril pushed a commit that referenced this pull request Dec 14, 2017
@sudheerDev @saturninoabril
PLT-7238 Migration of create_post.jsx to redux (#210)
8292b1c 
* Migrate create_post component to redux
 Remove channelId and channel from state as it is avaialable via props.
 Remove Team store dependency.
 Remove User store dependency
 Remove Preferences store dependency.
  * Remove preferences from store as props change trigger render.
  * Add selector for preferences
 Move REACTION_PATTERN to utils.
 Remove message_history_store dependency.
 Add redux post actions instead of flux actions.
 Change bind functions to class prop arrow functions.
 Add proptype comments.
 Remove couple of unused variables.
* Remove all bind functions.
* Add MESSAGE_TYPES constants.
Remove few postStore dependent functions.
Add getCurrentUsersLatestPostId redux state selector.
Add Test cases for create_post
Remove uploadInprogress and filesInfo from state
Remove unused variable from file_preview which causes mutation on props.
Fix sort on filesInfo for file_preview component.
Fix draft constant
Remove postStore dependecy.
Add edit dispatch from redux.
Add test cases
Fix failing snapshots.

* Fix review comments

* Fix member count in render for notifying user on @ALL

* Fix test cases
 Change currentChannelMembersCount default value to 1 as user is part of the channel.

* Fix for the value getCurrentChannelStats as on team creation and thread creation it is undefined.

* Adds inline make documentation and 'help' command. (#394)

* Fix atmention to check for user on users object only (#419)

* PLT-8237 - Updating modal textarea overflow (#414)

* [PLT-6940] Add webrtc call at channel navbar and make it available on narrow window (#17)

* add webrtc call at channel navbar and make it available on narrow window

* rebase

* updated and add unit tests

* update snapshot

* [PLT-8222] Add 100% height to root and fix setState warning on ManageLanguage component (#409)

* add 100% height to root and fix setState warning on ManageLanguage component

* update #root class and move other logics of LoggedIn to componentDidMount

* remove setState call on success updateUser

* add channelId to RECEIVED_POSTS action after edit (#424)

* Add deactivated users to dm modal (#401)

* add deactivated users to dm modal

* address pr comments

* Create NOTICE.txt (#376)

* Create NOTICE.txt

* Changed react to react-dom

* Update mattermost-redux to 1.1.0 (#417)

* Use CMD instead of CTRL for textbox focusing on Mac (#407)

* PLT-8236 Properly highlight at mentions for the current user which are followed by punctuation (#405)

* Reset post viewed count when switching channels (#373)

* Upgrade WebRTC client driver (#383)

* PLT-8170: Fix channel name / purpose modals (#416)

* fix channel name / purpose modals

* update snapshots

* another snapshot update

* Fixing LDAP nickname setting block. (#403)

* Remove hard-coded link to System Console stats docs (#393)

* Update system_analytics.jsx

* Update en.json

* Note that desktop notification duration is a max of 5 seconds for desktop apps (#362)

* Update desktop_notification_settings.jsx

* Update en.json

* Add Config to disable Auth Transfers. Remove frontend switch to email and password. (#328)

* remove the video call from the his own DM channel (#411)

* Backward compatible fix theme.mentionBg typo (#322)

* Backward compatible fix theme.mentionBg typo

* Save mentionBj with mentionBg

* Fix styling

* PLT-8292 - Updating webrtc button (#415)

* PLT-8292 - Updating webrtc button

* Updating webrtc conditional

* Add pluggable component in mobile channel header (#412)

* Add pluggable component in mobile channel header

* Fix styling

* Update snapshot

* Fix mobile view search button (#408)

* unit tests for AccessHistoryModal and ActivityLogModal (#413)

* remove unused type arg of UserActions.updateUser and remove unused/unnecessary Constants.UserUpdateEvents (#410)

* Create comment use the component state to show/edit the draft (#395)

* translations PR 20171204 (#402)

* Hide locale setting if there's a single locale available (#330)

* UCHAT-275 Add config option to hide locale setting

* Hide locale setting if there's a single locale available Ex: AvailableLocales: en

* PLT-8321: simplify isXVisible callsites (#428)

* simplify isXVisible callsites

* update package.json

* PLT-8198: System Console updates for message/compliance export (#390)

* Updated the text on the System Console settings page to approved copy

* Language fixes from the PR

* More text updates

* Removed export location setting from the UI

* Fixed style

* Fixed bug preventing user from enabling/disabling compliance export

* PLT-8198: System Console updates for message/compliance export (#390)

* Updated the text on the System Console settings page to approved copy

* Language fixes from the PR

* More text updates

* Removed export location setting from the UI

* Fixed style

* Fixed bug preventing user from enabling/disabling compliance export

(cherry picked from commit a9107f3)

* Update NOTICE.txt (#426)

* Avoid creating a new EmojiMap for each post (#431)

* Avoid creating a new EmojiMap for each post

* Removed debug message

* fix js error in dm add user modal (#437)

* Allow deactivation of SSO users (#423)

* Update jenkinsfile (#444)

* add test to AccountSettingsDisplay modal (#440)

* change inline arrow function in ref (#449)

* Fix jenkinsfile s3 push (#452)

* Fix typo in audit table component (#427)

* Fix typo in audit table component

* Updating i18n strings as well, as requested

* Added PostMarkdown component (#404)

* Added PostMarkdown component

* Fixed failing tests

* Fixing styles

* add unit test to AddUsersToTeam and fix function/unused codes (#420)

* Remove div container taking up width (#425)

this blocks users from clicking messages directly behind the NewMessageIndicator compnent

* Fix mutation on draft file remove

* Migrate do_verify_email to Redux (#338)

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display

* Code Review Fixes

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**

* Fix Tests

* Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display

* Code Review Fixes

* WIP: Changes to testing

Work in Progress, last two tests returning errors.

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
Code Review Fixes


Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
WIP: Changes to testing

Work in Progress, last two tests returning errors.
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
WIP: Changes to testing

Work in Progress, last two tests returning errors.
Code Review Fixes


Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784
Fixed test errors


Fix test name


Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784

* Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
Code Review Fixes


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
WIP: Changes to testing

Work in Progress, last two tests returning errors.
Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
Code Review Fixes


Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
WIP: Changes to testing

Work in Progress, last two tests returning errors.
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Migrate do_verify_email to Redux

**Should wait until enzyme & react version issues are resolved**
Fix Tests


Finalized component tests

* Snapshot test
* verifyEmail function test
* Test mattermost-redux action & error display
WIP: Changes to testing

Work in Progress, last two tests returning errors.
Code Review Fixes


Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784
Fixed test errors


Fix test name


Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784
Remove useless Adapter import in test


Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784
Merge remote-tracking branch 'avasconcelos114/PLT-7784' into PLT-7784

* Fix merge issue

* Migrate create_post component to redux
 Remove channelId and channel from state as it is avaialable via props.
 Remove Team store dependency.
 Remove User store dependency
 Remove Preferences store dependency.
  * Remove preferences from store as props change trigger render.
  * Add selector for preferences
 Move REACTION_PATTERN to utils.
 Remove message_history_store dependency.
 Add redux post actions instead of flux actions.
 Change bind functions to class prop arrow functions.
 Add proptype comments.
 Remove couple of unused variables.
* Remove all bind functions.
* Add MESSAGE_TYPES constants.
Remove few postStore dependent functions.
Add getCurrentUsersLatestPostId redux state selector.
Add Test cases for create_post
Remove uploadInprogress and filesInfo from state
Remove unused variable from file_preview which causes mutation on props.
Fix sort on filesInfo for file_preview component.
Fix draft constant
Remove postStore dependecy.
Add edit dispatch from redux.
Add test cases
Fix failing snapshots.

* Fix review comments

* Fix member count in render for notifying user on @ALL

* Fix test cases
 Change currentChannelMembersCount default value to 1 as user is part of the channel.

* Fix for the value getCurrentChannelStats as on team creation and thread creation it is undefined.

* Fix mutation on draft file remove
@jasonblais jasonblais added Changelog/Done Required changelog entry has been written Docs/Done Required documentation has been written labels Jan 4, 2018
@dmeza dmeza deleted the bash-11_disable-auth-transfer branch December 7, 2018 18:28
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@enahum @hmhealey
Replace analytics context with global (#328)
5653083
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@enahum @hmhealey
Replace analytics context with global (#328)
7c5c77c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ccbrown ccbrown ccbrown approved these changes

@jwilander jwilander jwilander approved these changes

@jasonblais jasonblais jasonblais approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Done Required documentation has been written Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.5.0
7 participants
@csduarte @dmeza @lindalumitchell @ccbrown @jwilander @jasonblais @jarredwitt