Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-18897] Fix paragraphs in post markdown preview #3800

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

mickmister
Copy link
Member

@mickmister mickmister commented Sep 29, 2019

Summary

This PR fixes the issue with the markdown preview feature, where new paragraphs are rendered with no newline between them.

This was fixed before, during a fix for whitespace in ul elements Ticket and PR. This PR scopes that fix to only apply to ul elements.

Ticket Link

https://mattermost.atlassian.net/browse/MM-18897

@mickmister mickmister added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 29, 2019
@mickmister
Copy link
Member Author

Original source
source

Before fix
bad-preview

After fix
good-preview

Source for list issue from previous PR
ul-source

list issue still fixed
ul-preview

@lindalumitchell
Copy link
Contributor

LGTM. Wondering, though: the ticket is marked for v5.17, so will we need to remember to cherry-pick this after v5.16 ships? Not sure how that usually works. @mickmister @lieut-data

@lindalumitchell lindalumitchell added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Sep 30, 2019
@lieut-data
Copy link
Member

Good point. We can either merge this early to v5.16, or if QA prefers, hold off and wait for v5.17 to be branched. Do you have a preference, @lindalumitchell?

@lindalumitchell
Copy link
Contributor

Did you mean early to v5.18? I would prefer it goes into v5.17, if there's a good way to make that happen (if it's not too out-of-process).

@lieut-data
Copy link
Member

@lindalumitchell, no, I meant we could just mark this bug fix for v5.16 and merge directly there. Maybe let's discuss at triage?

@lindalumitchell
Copy link
Contributor

Ah I see, yes. I think that would probably be fine; I queued for triage to discuss. @lieut-data

@amyblais amyblais added this to the v5.17.0 milestone Sep 30, 2019
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 30, 2019
@amyblais amyblais modified the milestones: v5.17.0, v5.16.0 Sep 30, 2019
@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Sep 30, 2019
@mickmister mickmister added the 4: Reviews Complete All reviewers have approved the pull request label Sep 30, 2019
@mickmister mickmister merged commit 15aa543 into mattermost:master Sep 30, 2019
@mickmister mickmister deleted the MM-18897-preview-newlines branch September 30, 2019 17:11
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 30, 2019
mickmister pushed a commit that referenced this pull request Sep 30, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 30, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
6 participants