Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14714 - Updating textarea preview #2612

Merged
merged 1 commit into from
Apr 24, 2019
Merged

MM-14714 - Updating textarea preview #2612

merged 1 commit into from
Apr 24, 2019

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-14714 - Updating textarea preview

Ticket Link

https://mattermost.atlassian.net/browse/MM-14714

Related Pull Requests

  • Has server changes (please link here)
  • Has redux changes (please link here)
  • Has mobile changes (please link here)

@asaadmahmood asaadmahmood added the 2: Dev Review Requires review by a core commiter label Apr 4, 2019
@asaadmahmood asaadmahmood added this to the v5.11.0 milestone Apr 4, 2019
cpanato
cpanato approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be good to have a screenshot with after and before this change

@asaadmahmood
Copy link
Contributor Author

Before:
|Screenshot 2019-04-04 at 5 31 40 PM

After:
Screenshot 2019-04-04 at 5 31 18 PM

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels Apr 24, 2019
@amyblais
Copy link
Member

Can somebody help merge + cherry pick?

@hanzei hanzei self-assigned this Apr 24, 2019
@hanzei hanzei merged commit 8f55f84 into mattermost:master Apr 24, 2019
hanzei pushed a commit that referenced this pull request Apr 24, 2019
@asaadmahmood @hanzei
MM-14714 - Updating textarea preview (#2612)
a3d6893
@hanzei hanzei added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 24, 2019
@asaadmahmood asaadmahmood deleted the MM-14714 branch April 24, 2019 13:39
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Apr 24, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 26, 2019
@mickmister mickmister mentioned this pull request Sep 29, 2019
Merged
@hanzei hanzei removed their assignment Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@asaadmahmood @amyblais @cpanato @enahum @lindy65 @hanzei