This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-17253] Change to using ‘postMessage’ for desktop presence detection #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanwhillier
added
2: Dev Review
lieut-data
suggested changes
Aug 28, 2019
|
@deanwhillier Can you help add any known test steps to the ticket please? |
lieut-data
approved these changes
Aug 28, 2019
amyblais
added
CherryPick/Approved
|
Thanks for catching that @lieut-data! @lindalumitchell, you can reference the test cases on this PR (I will add the link to the ticket as well) |
|
Thanks! Removed QA Review label; will test along with other PRs after merging. |
enahum
approved these changes
Aug 29, 2019
enahum
added
4: Reviews Complete
mattermod
added
AutomatedCherryPick
and removed
CherryPick/Approved
enahum
pushed a commit
that referenced
this pull request
Aug 29, 2019
amyblais
added
Changelog/Not Needed
|
@esethna Please help check if this needs documentation for v5.15. |
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…on (mattermost#3548) * change to ‘postMessage’ for desktop integration * remove unused reference * remove old connector
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
…on (mattermost#3548) * change to ‘postMessage’ for desktop integration * remove unused reference * remove old connector
esethna
added
Docs/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a result of a security update to the Desktop app (context isolation), the Desktop <-> Webapp communication for presence detection broke. This PR changes the communication mechanism to use
postMessagein order to get Desktop <-> Webapp communication working again.Ticket Link
https://mattermost.atlassian.net/browse/MM-17253
Related Pull Requests