Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-17251] Change to using ‘postMessage’ for desktop presence detection #1026

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

deanwhillier
Copy link
Contributor

@deanwhillier deanwhillier commented Aug 28, 2019

Summary

As a result of a security update to the Desktop app (context isolation), the Desktop <-> Webapp communication for presence detection broke. This PR changes the communication mechanism to use postMessage in order to get Desktop <-> Webapp communication working again.

Issue link

https://mattermost.atlassian.net/browse/MM-17251

Related Pull Requests

Webapp: mattermost/mattermost-webapp#3548

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core committer label Sep 1, 2019
@lindalumitchell
Copy link

Are there description and test steps that can be added to the ticket for this one?

@enahum
Copy link
Contributor

enahum commented Sep 5, 2019

Basically the idea here is to have the status changing when the user is away or present, this was already done but a secfix broke this, this PR is intended to fix it back to how it was.

☝️As far as I can tell

@deanwhillier
Copy link
Contributor Author

@lindalumitchel, the description and test steps from the original PR can be used for this one. I’ll add to the ticket as well.

@lindalumitchell
Copy link

Thanks @enahum and @deanwhillier! I tried to remove the QA label, but it looks like I don't have permission in this repo to add/remove labels, so for now can you please remove QA Review label for me, and then for future, does anyone know who I should ask to get permission in this repo to remove those labels myself?

@deanwhillier deanwhillier removed the 3: QA Review Requires review by a QA tester label Sep 6, 2019
@amyblais amyblais added the 4: Reviews Complete All reviewers have approved the pull request label Sep 6, 2019
@deanwhillier deanwhillier force-pushed the MM-17251_presence-detection-updates branch from aa74216 to b00d477 Compare September 9, 2019 14:11
@deanwhillier
Copy link
Contributor Author

Added pipeline fixes from @Willyfrog, tests are now running again and passing!

@deanwhillier deanwhillier merged commit f12f9da into master Sep 9, 2019
@deanwhillier deanwhillier deleted the MM-17251_presence-detection-updates branch September 9, 2019 16:33
JtheBAB pushed a commit to JtheBAB/desktop that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants