Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

E2E: Fix flaky test on markdown and team specs #3099

Merged
merged 1 commit into from
Jul 12, 2019
Merged

E2E: Fix flaky test on markdown and team specs #3099

merged 1 commit into from
Jul 12, 2019

Conversation

saturninoabril
Copy link
Member

Summary

Fix flaky test on

  • markdown/markdown_text_spec.js
  • team/teams_spec.js

Note that this is submitted on top of another PR. Will rebase once it's merged or the issue there is fixed.

Ticket Link

n/a but based on Daily Cypress test 104

@saturninoabril saturninoabril added the 2: Dev Review Requires review by a core commiter label Jul 11, 2019
saturninoabril
saturninoabril commented Jul 11, 2019
View reviewed changes
e2e/cypress/integration/markdown/markdown_text_spec.js

// # Navigate to app and wait for posts request to finish
cy.visit('/');
cy.wait('@getPosts', {timeout: TIMEOUTS.HUGE}).should('have.property', 'status', 200);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not particularly sure why this was added but my guess is that previous tests makes the posts load loner than usual. So, just do this test with new user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what I was aiming for initially, but this solves it :)

saturninoabril
saturninoabril commented Jul 11, 2019
View reviewed changes
e2e/cypress/integration/team/teams_spec.js
@@ -15,7 +15,7 @@ function removeTeamMember(teamURL, username) {
cy.apiLogout();
cy.apiLogin('sysadmin');
cy.visit(`/${teamURL}`);
cy.get('#sidebarHeaderDropdownButton').click();
cy.get('#sidebarHeaderDropdownButton').should('be.visible').click();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buy some time by checking that the button is actually visible before clicking.

@saturninoabril saturninoabril added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jul 11, 2019
srkgupta
srkgupta suggested changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could combine the steps to loginAsNewUser and createTeam into a single function and use it across multiple tests, the rest of the code changes looks fine.

e2e/cypress/integration/markdown/markdown_image_spec.js Show resolved Hide resolved
@saturninoabril saturninoabril changed the title Fix e2e 11 E2E: Fix flaky test on markdown and team specs Jul 11, 2019
srkgupta
srkgupta approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Jul 12, 2019
@saturninoabril saturninoabril merged commit 76b532f into mattermost:master Jul 12, 2019
@saturninoabril saturninoabril deleted the fix-e2e-11 branch July 12, 2019 06:38
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 12, 2019
jespino added a commit that referenced this pull request Jul 15, 2019
@jespino
Handling redirects on leave channel for guests (#3068)
c0b876d 
* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (#3087)

* Fixing broken permalinks when access directly to the app (#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (#3092)

* Listen to route to fix search date filter e2e tests (#3107)

* UX screen review fixes for Admin Console Teams/Channels (#3058)



Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (#3114)
jespino added a commit that referenced this pull request Jul 22, 2019
@jespino
Guest Accounts Feature (#3027)
7194ff2 
* MM-15056: Adding Guest badge to identify guest users (#2745)

* MM-15056: Adding Guest badge to identify guest users

* Fixing i18n

* Refactoring bot badges to a component (#2750)

* Updating tests

* Add permissions checks needed for guest accounts (#2782)

* Add permissions checks needed for guest accounts

* Fixing bug

* Fixing lint

* Add Invitation modal (#2820)

* Add Invitation modal

* Adding guest badges to the users in the users_emails input selector

* Adding the guest badges where is needed

* Fixing small bug showing channel title guest badges

* Fixing username formating

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Moving Invite types to constants

* Moving formatUserName to utils and renamed

* Replacing some FormatedMarkdownMessage with FormattedMessage

* Removing empty dialogProps usages

* Reusing getDisplayName and getLongDisplayName in users_emails_input component

* Error handling on search profiles file

* Fixing tests

* Removing duplicated import

* fixing check styles

* Removing unnused i18n strings

* Fixing tests

* Upgrading the mattermost-redux library

* Implementing dark theme for the invitation flow (#2976)

* Implementing dark theme for invitation flow

* Fixing some styles

* Changes to manage guests (admin console and manage channel and team members) (#3019)

* Changes to manage guests (admin console and manage channel and team members)

* Fixing tests

* Fixing i18n-check

* Fixing tests

* Adding guest filtering to the interface

* Addressing texts changes proposed by Katie

* Upgrading to the last mattermost-redux version

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Fixing translation strings

* Updating redux version

* First iteration on styling comments for invitation flow (#3062)

* First iteration on styling comments for invitation flow

* Fixing i18n

* Fixing tests

* Adding extra small adjustments

* Updating redux version

* Administration permissions and guest account settings (#3039)

* Administration permissions and guest account settings

* Using constants for permissions

* Using constants instead of strings for roles

* Adding the proper link icon in the copy link button (#3104)

* Adding the proper link icon in the copy link button

* Adding missed i18n string

* Allow to go back from confirmation screen (#3110)

* Allow to go back from confirmation screen

* Fixing tests

* Adding loading spinner to inputs (#3103)

* Fixing help text of guest invitation users/emails input (#3111)

* Fixing help text of guest invitation users/emails input

* Updating snapshots

* Fix confirm back/close behavior in the invitation flow modal (#3108)

* Fix confirm back/close behavior in the invitation flow modal

* Addressing PR comments

* Fixing copy button on invitation flow (#3102)

* Fixing copy button

* Fixing tests

* Small code improvement

* Handling redirects on leave channel for guests (#3068)

* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (#3087)

* Fixing broken permalinks when access directly to the app (#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (#3092)

* Listen to route to fix search date filter e2e tests (#3107)

* UX screen review fixes for Admin Console Teams/Channels (#3058)



Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (#3114)

* Fixing email invitations disabled problem (#3126)

* Fixing email invitations disabled problem

* fixing lint

* Fixing small errors

* Polishing details in invitation flow styles (#3143)

* Polishing details in invitation flow styles

* Fixing eslint

* Adding header warning for guests in channels (#3146)

* Adding header warning for guests in channels

* Adding i18n strings

* Fixing i18n

* Updating snapshot

* Fixing guest disabled and no license on invitation modal (#3158)

* Add invite guest permission to the admin console (#3167)

* More style fixes (#3150)

* More fixes

* Changing a text

* Adding beta label to the feature

* Updating snapshots

* Some more fixes to bugs found by QA (#3184)

* Fixing bug on close confirmation

* Fixing invite existing guest to a new team

* fixing padding on mobile

* Reducing the number of requests when is possible

* Adding the Guest role to user card in the admin console (#3186)

* Updating to the last mattermost-redux version
jespino added a commit to jespino/mattermost-webapp that referenced this pull request Jul 22, 2019
@jespino
Guest Accounts Feature (mattermost#3027)
653908b 
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745)

* MM-15056: Adding Guest badge to identify guest users

* Fixing i18n

* Refactoring bot badges to a component (mattermost#2750)

* Updating tests

* Add permissions checks needed for guest accounts (mattermost#2782)

* Add permissions checks needed for guest accounts

* Fixing bug

* Fixing lint

* Add Invitation modal (mattermost#2820)

* Add Invitation modal

* Adding guest badges to the users in the users_emails input selector

* Adding the guest badges where is needed

* Fixing small bug showing channel title guest badges

* Fixing username formating

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Moving Invite types to constants

* Moving formatUserName to utils and renamed

* Replacing some FormatedMarkdownMessage with FormattedMessage

* Removing empty dialogProps usages

* Reusing getDisplayName and getLongDisplayName in users_emails_input component

* Error handling on search profiles file

* Fixing tests

* Removing duplicated import

* fixing check styles

* Removing unnused i18n strings

* Fixing tests

* Upgrading the mattermost-redux library

* Implementing dark theme for the invitation flow (mattermost#2976)

* Implementing dark theme for invitation flow

* Fixing some styles

* Changes to manage guests (admin console and manage channel and team members) (mattermost#3019)

* Changes to manage guests (admin console and manage channel and team members)

* Fixing tests

* Fixing i18n-check

* Fixing tests

* Adding guest filtering to the interface

* Addressing texts changes proposed by Katie

* Upgrading to the last mattermost-redux version

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Fixing translation strings

* Updating redux version

* First iteration on styling comments for invitation flow (mattermost#3062)

* First iteration on styling comments for invitation flow

* Fixing i18n

* Fixing tests

* Adding extra small adjustments

* Updating redux version

* Administration permissions and guest account settings (mattermost#3039)

* Administration permissions and guest account settings

* Using constants for permissions

* Using constants instead of strings for roles

* Adding the proper link icon in the copy link button (mattermost#3104)

* Adding the proper link icon in the copy link button

* Adding missed i18n string

* Allow to go back from confirmation screen (mattermost#3110)

* Allow to go back from confirmation screen

* Fixing tests

* Adding loading spinner to inputs (mattermost#3103)

* Fixing help text of guest invitation users/emails input (mattermost#3111)

* Fixing help text of guest invitation users/emails input

* Updating snapshots

* Fix confirm back/close behavior in the invitation flow modal (mattermost#3108)

* Fix confirm back/close behavior in the invitation flow modal

* Addressing PR comments

* Fixing copy button on invitation flow (mattermost#3102)

* Fixing copy button

* Fixing tests

* Small code improvement

* Handling redirects on leave channel for guests (mattermost#3068)

* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (mattermost#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (mattermost#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (mattermost#3087)

* Fixing broken permalinks when access directly to the app (mattermost#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (mattermost#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (mattermost#3092)

* Listen to route to fix search date filter e2e tests (mattermost#3107)

* UX screen review fixes for Admin Console Teams/Channels (mattermost#3058)

Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (mattermost#3114)

* Fixing email invitations disabled problem (mattermost#3126)

* Fixing email invitations disabled problem

* fixing lint

* Fixing small errors

* Polishing details in invitation flow styles (mattermost#3143)

* Polishing details in invitation flow styles

* Fixing eslint

* Adding header warning for guests in channels (mattermost#3146)

* Adding header warning for guests in channels

* Adding i18n strings

* Fixing i18n

* Updating snapshot

* Fixing guest disabled and no license on invitation modal (mattermost#3158)

* Add invite guest permission to the admin console (mattermost#3167)

* More style fixes (mattermost#3150)

* More fixes

* Changing a text

* Adding beta label to the feature

* Updating snapshots

* Some more fixes to bugs found by QA (mattermost#3184)

* Fixing bug on close confirmation

* Fixing invite existing guest to a new team

* fixing padding on mobile

* Reducing the number of requests when is possible

* Adding the Guest role to user card in the admin console (mattermost#3186)

* Updating to the last mattermost-redux version
@jespino jespino mentioned this pull request Jul 22, 2019
Merged
jespino added a commit that referenced this pull request Jul 22, 2019
@jespino
Guest Accounts Feature (#3027) (#3205)
2c3197d 
* MM-15056: Adding Guest badge to identify guest users (#2745)

* MM-15056: Adding Guest badge to identify guest users

* Fixing i18n

* Refactoring bot badges to a component (#2750)

* Updating tests

* Add permissions checks needed for guest accounts (#2782)

* Add permissions checks needed for guest accounts

* Fixing bug

* Fixing lint

* Add Invitation modal (#2820)

* Add Invitation modal

* Adding guest badges to the users in the users_emails input selector

* Adding the guest badges where is needed

* Fixing small bug showing channel title guest badges

* Fixing username formating

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Moving Invite types to constants

* Moving formatUserName to utils and renamed

* Replacing some FormatedMarkdownMessage with FormattedMessage

* Removing empty dialogProps usages

* Reusing getDisplayName and getLongDisplayName in users_emails_input component

* Error handling on search profiles file

* Fixing tests

* Removing duplicated import

* fixing check styles

* Removing unnused i18n strings

* Fixing tests

* Upgrading the mattermost-redux library

* Implementing dark theme for the invitation flow (#2976)

* Implementing dark theme for invitation flow

* Fixing some styles

* Changes to manage guests (admin console and manage channel and team members) (#3019)

* Changes to manage guests (admin console and manage channel and team members)

* Fixing tests

* Fixing i18n-check

* Fixing tests

* Adding guest filtering to the interface

* Addressing texts changes proposed by Katie

* Upgrading to the last mattermost-redux version

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Fixing translation strings

* Updating redux version

* First iteration on styling comments for invitation flow (#3062)

* First iteration on styling comments for invitation flow

* Fixing i18n

* Fixing tests

* Adding extra small adjustments

* Updating redux version

* Administration permissions and guest account settings (#3039)

* Administration permissions and guest account settings

* Using constants for permissions

* Using constants instead of strings for roles

* Adding the proper link icon in the copy link button (#3104)

* Adding the proper link icon in the copy link button

* Adding missed i18n string

* Allow to go back from confirmation screen (#3110)

* Allow to go back from confirmation screen

* Fixing tests

* Adding loading spinner to inputs (#3103)

* Fixing help text of guest invitation users/emails input (#3111)

* Fixing help text of guest invitation users/emails input

* Updating snapshots

* Fix confirm back/close behavior in the invitation flow modal (#3108)

* Fix confirm back/close behavior in the invitation flow modal

* Addressing PR comments

* Fixing copy button on invitation flow (#3102)

* Fixing copy button

* Fixing tests

* Small code improvement

* Handling redirects on leave channel for guests (#3068)

* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (#3087)

* Fixing broken permalinks when access directly to the app (#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (#3092)

* Listen to route to fix search date filter e2e tests (#3107)

* UX screen review fixes for Admin Console Teams/Channels (#3058)

Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (#3114)

* Fixing email invitations disabled problem (#3126)

* Fixing email invitations disabled problem

* fixing lint

* Fixing small errors

* Polishing details in invitation flow styles (#3143)

* Polishing details in invitation flow styles

* Fixing eslint

* Adding header warning for guests in channels (#3146)

* Adding header warning for guests in channels

* Adding i18n strings

* Fixing i18n

* Updating snapshot

* Fixing guest disabled and no license on invitation modal (#3158)

* Add invite guest permission to the admin console (#3167)

* More style fixes (#3150)

* More fixes

* Changing a text

* Adding beta label to the feature

* Updating snapshots

* Some more fixes to bugs found by QA (#3184)

* Fixing bug on close confirmation

* Fixing invite existing guest to a new team

* fixing padding on mobile

* Reducing the number of requests when is possible

* Adding the Guest role to user card in the admin console (#3186)

* Updating to the last mattermost-redux version
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@saturninoabril @skheria
fix flaky test on markdown and teams spec (mattermost#3099)
dc0b082
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Guest Accounts Feature (mattermost#3027)
4386d2a 
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745)

* MM-15056: Adding Guest badge to identify guest users

* Fixing i18n

* Refactoring bot badges to a component (mattermost#2750)

* Updating tests

* Add permissions checks needed for guest accounts (mattermost#2782)

* Add permissions checks needed for guest accounts

* Fixing bug

* Fixing lint

* Add Invitation modal (mattermost#2820)

* Add Invitation modal

* Adding guest badges to the users in the users_emails input selector

* Adding the guest badges where is needed

* Fixing small bug showing channel title guest badges

* Fixing username formating

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Moving Invite types to constants

* Moving formatUserName to utils and renamed

* Replacing some FormatedMarkdownMessage with FormattedMessage

* Removing empty dialogProps usages

* Reusing getDisplayName and getLongDisplayName in users_emails_input component

* Error handling on search profiles file

* Fixing tests

* Removing duplicated import

* fixing check styles

* Removing unnused i18n strings

* Fixing tests

* Upgrading the mattermost-redux library

* Implementing dark theme for the invitation flow (mattermost#2976)

* Implementing dark theme for invitation flow

* Fixing some styles

* Changes to manage guests (admin console and manage channel and team members) (mattermost#3019)

* Changes to manage guests (admin console and manage channel and team members)

* Fixing tests

* Fixing i18n-check

* Fixing tests

* Adding guest filtering to the interface

* Addressing texts changes proposed by Katie

* Upgrading to the last mattermost-redux version

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Fixing translation strings

* Updating redux version

* First iteration on styling comments for invitation flow (mattermost#3062)

* First iteration on styling comments for invitation flow

* Fixing i18n

* Fixing tests

* Adding extra small adjustments

* Updating redux version

* Administration permissions and guest account settings (mattermost#3039)

* Administration permissions and guest account settings

* Using constants for permissions

* Using constants instead of strings for roles

* Adding the proper link icon in the copy link button (mattermost#3104)

* Adding the proper link icon in the copy link button

* Adding missed i18n string

* Allow to go back from confirmation screen (mattermost#3110)

* Allow to go back from confirmation screen

* Fixing tests

* Adding loading spinner to inputs (mattermost#3103)

* Fixing help text of guest invitation users/emails input (mattermost#3111)

* Fixing help text of guest invitation users/emails input

* Updating snapshots

* Fix confirm back/close behavior in the invitation flow modal (mattermost#3108)

* Fix confirm back/close behavior in the invitation flow modal

* Addressing PR comments

* Fixing copy button on invitation flow (mattermost#3102)

* Fixing copy button

* Fixing tests

* Small code improvement

* Handling redirects on leave channel for guests (mattermost#3068)

* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (mattermost#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (mattermost#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (mattermost#3087)

* Fixing broken permalinks when access directly to the app (mattermost#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (mattermost#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (mattermost#3092)

* Listen to route to fix search date filter e2e tests (mattermost#3107)

* UX screen review fixes for Admin Console Teams/Channels (mattermost#3058)



Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (mattermost#3114)

* Fixing email invitations disabled problem (mattermost#3126)

* Fixing email invitations disabled problem

* fixing lint

* Fixing small errors

* Polishing details in invitation flow styles (mattermost#3143)

* Polishing details in invitation flow styles

* Fixing eslint

* Adding header warning for guests in channels (mattermost#3146)

* Adding header warning for guests in channels

* Adding i18n strings

* Fixing i18n

* Updating snapshot

* Fixing guest disabled and no license on invitation modal (mattermost#3158)

* Add invite guest permission to the admin console (mattermost#3167)

* More style fixes (mattermost#3150)

* More fixes

* Changing a text

* Adding beta label to the feature

* Updating snapshots

* Some more fixes to bugs found by QA (mattermost#3184)

* Fixing bug on close confirmation

* Fixing invite existing guest to a new team

* fixing padding on mobile

* Reducing the number of requests when is possible

* Adding the Guest role to user card in the admin console (mattermost#3186)

* Updating to the last mattermost-redux version
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@saturninoabril @skheria
fix flaky test on markdown and teams spec (mattermost#3099)
4902313
skheria pushed a commit to uber-archive/mattermost-webapp that referenced this pull request Oct 3, 2019
@jespino @skheria
Guest Accounts Feature (mattermost#3027)
abba17a 
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745)

* MM-15056: Adding Guest badge to identify guest users

* Fixing i18n

* Refactoring bot badges to a component (mattermost#2750)

* Updating tests

* Add permissions checks needed for guest accounts (mattermost#2782)

* Add permissions checks needed for guest accounts

* Fixing bug

* Fixing lint

* Add Invitation modal (mattermost#2820)

* Add Invitation modal

* Adding guest badges to the users in the users_emails input selector

* Adding the guest badges where is needed

* Fixing small bug showing channel title guest badges

* Fixing username formating

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Martin Kraft <[email protected]>

* Moving Invite types to constants

* Moving formatUserName to utils and renamed

* Replacing some FormatedMarkdownMessage with FormattedMessage

* Removing empty dialogProps usages

* Reusing getDisplayName and getLongDisplayName in users_emails_input component

* Error handling on search profiles file

* Fixing tests

* Removing duplicated import

* fixing check styles

* Removing unnused i18n strings

* Fixing tests

* Upgrading the mattermost-redux library

* Implementing dark theme for the invitation flow (mattermost#2976)

* Implementing dark theme for invitation flow

* Fixing some styles

* Changes to manage guests (admin console and manage channel and team members) (mattermost#3019)

* Changes to manage guests (admin console and manage channel and team members)

* Fixing tests

* Fixing i18n-check

* Fixing tests

* Adding guest filtering to the interface

* Addressing texts changes proposed by Katie

* Upgrading to the last mattermost-redux version

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Update i18n/en.json

Co-Authored-By: Miguel de la Cruz <[email protected]>

* Fixing translation strings

* Updating redux version

* First iteration on styling comments for invitation flow (mattermost#3062)

* First iteration on styling comments for invitation flow

* Fixing i18n

* Fixing tests

* Adding extra small adjustments

* Updating redux version

* Administration permissions and guest account settings (mattermost#3039)

* Administration permissions and guest account settings

* Using constants for permissions

* Using constants instead of strings for roles

* Adding the proper link icon in the copy link button (mattermost#3104)

* Adding the proper link icon in the copy link button

* Adding missed i18n string

* Allow to go back from confirmation screen (mattermost#3110)

* Allow to go back from confirmation screen

* Fixing tests

* Adding loading spinner to inputs (mattermost#3103)

* Fixing help text of guest invitation users/emails input (mattermost#3111)

* Fixing help text of guest invitation users/emails input

* Updating snapshots

* Fix confirm back/close behavior in the invitation flow modal (mattermost#3108)

* Fix confirm back/close behavior in the invitation flow modal

* Addressing PR comments

* Fixing copy button on invitation flow (mattermost#3102)

* Fixing copy button

* Fixing tests

* Small code improvement

* Handling redirects on leave channel for guests (mattermost#3068)

* Allow to leave default channels if you are a guest

* On guests without teams enter show an error message

* Fixing channel redirections on leaveChannel guest cases

* Fixing i18n

* Fixing tests and addressing PR comments

* Fixing tests

* MM-16044 - Updating radio buttons (a11y) (mattermost#3085)

* MM-16044 - Updating radio buttons (a11y)

* Updating test

* fix flaky test on markdown and teams spec (mattermost#3099)

* Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069)

* Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links"
Added 2 methods to api commands to create/login new user without turning off the tutorial preference.

* Cleaned up ESLINT errors

* Cleaned up ESLINT errors

* Made requested changes.

* Second round of suggestions from Pull Request

* Fixed href request

* fix unit test and browser JS warning (mattermost#3087)

* Fixing broken permalinks when access directly to the app (mattermost#3105)

* [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094)

* [MM-16533] fixed a couple bugs; always display deactivateMemberModal

* PR comment

* Allow to go back from confirmation screen

* Fixing tests

* [MM-16379] Accessibility Navigation Controller (mattermost#3047)

* accessibility controller and related updates

# Conflicts:
#	components/root/root.jsx
#	components/search_bar/search_bar.jsx
#	components/sidebar/header/sidebar_header.jsx
#	components/sidebar/sidebar.jsx

* reset navigation following intra region navigation

* remove old a11y event constants

* update snapshots

* check-style updates

* add a11y events into rhs posts

* update dom references to the preferred method

* react components inform conroller when updated

* added missing constants

* only dispatch update events when a11y active

* review update

* remove temp console.log’s

* fix mouse click visual glitch

* change keyboard-focus class to a11y—focused

* allow post to receive tab focus

* remove exception for posts reset

* only apply a11y visual outline when using a11y nav

* maintain flag button visual outline on enter

* better handling of certain key combinations

* fix test issue

* disable controller when bootstrap modal is open

* handle modals and pop ups

* add overide for section navigation looping

* remove console.logs

* fix Cypress run script (mattermost#3092)

* Listen to route to fix search date filter e2e tests (mattermost#3107)

* UX screen review fixes for Admin Console Teams/Channels (mattermost#3058)



Co-authored-by: Martin Kraft <[email protected]>

* MM-16081 - Updating aria label for team buttons (mattermost#3114)

* Fixing email invitations disabled problem (mattermost#3126)

* Fixing email invitations disabled problem

* fixing lint

* Fixing small errors

* Polishing details in invitation flow styles (mattermost#3143)

* Polishing details in invitation flow styles

* Fixing eslint

* Adding header warning for guests in channels (mattermost#3146)

* Adding header warning for guests in channels

* Adding i18n strings

* Fixing i18n

* Updating snapshot

* Fixing guest disabled and no license on invitation modal (mattermost#3158)

* Add invite guest permission to the admin console (mattermost#3167)

* More style fixes (mattermost#3150)

* More fixes

* Changing a text

* Adding beta label to the feature

* Updating snapshots

* Some more fixes to bugs found by QA (mattermost#3184)

* Fixing bug on close confirmation

* Fixing invite existing guest to a new team

* fixing padding on mobile

* Reducing the number of requests when is possible

* Adding the Guest role to user card in the admin console (mattermost#3186)

* Updating to the last mattermost-redux version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thekiiingbob thekiiingbob thekiiingbob approved these changes

@srkgupta srkgupta srkgupta approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
4 participants
@saturninoabril @thekiiingbob @srkgupta @amyblais