This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-16044 - Updating radio buttons (a11y) #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
approved these changes
Jul 11, 2019
jwilander
added
3: QA Review
|
Code looks good but we should probably have QA look at it before it's merged |
jwilander
added
the
Setup Cloud Test Server
esethna
approved these changes
Jul 11, 2019
esethna
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
lindy65
removed
the
4: Reviews Complete
jespino
added a commit
that referenced
this pull request
Jul 15, 2019
* Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (#3099) * Cypress automated test for "Tutorial - Navigation and Links" (#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (#3087) * Fixing broken permalinks when access directly to the app (#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (#3092) * Listen to route to fix search date filter e2e tests (#3107) * UX screen review fixes for Admin Console Teams/Channels (#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (#3114)
jespino
added a commit
that referenced
this pull request
Jul 22, 2019
* MM-15056: Adding Guest badge to identify guest users (#2745) * MM-15056: Adding Guest badge to identify guest users * Fixing i18n * Refactoring bot badges to a component (#2750) * Updating tests * Add permissions checks needed for guest accounts (#2782) * Add permissions checks needed for guest accounts * Fixing bug * Fixing lint * Add Invitation modal (#2820) * Add Invitation modal * Adding guest badges to the users in the users_emails input selector * Adding the guest badges where is needed * Fixing small bug showing channel title guest badges * Fixing username formating * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Moving Invite types to constants * Moving formatUserName to utils and renamed * Replacing some FormatedMarkdownMessage with FormattedMessage * Removing empty dialogProps usages * Reusing getDisplayName and getLongDisplayName in users_emails_input component * Error handling on search profiles file * Fixing tests * Removing duplicated import * fixing check styles * Removing unnused i18n strings * Fixing tests * Upgrading the mattermost-redux library * Implementing dark theme for the invitation flow (#2976) * Implementing dark theme for invitation flow * Fixing some styles * Changes to manage guests (admin console and manage channel and team members) (#3019) * Changes to manage guests (admin console and manage channel and team members) * Fixing tests * Fixing i18n-check * Fixing tests * Adding guest filtering to the interface * Addressing texts changes proposed by Katie * Upgrading to the last mattermost-redux version * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Fixing translation strings * Updating redux version * First iteration on styling comments for invitation flow (#3062) * First iteration on styling comments for invitation flow * Fixing i18n * Fixing tests * Adding extra small adjustments * Updating redux version * Administration permissions and guest account settings (#3039) * Administration permissions and guest account settings * Using constants for permissions * Using constants instead of strings for roles * Adding the proper link icon in the copy link button (#3104) * Adding the proper link icon in the copy link button * Adding missed i18n string * Allow to go back from confirmation screen (#3110) * Allow to go back from confirmation screen * Fixing tests * Adding loading spinner to inputs (#3103) * Fixing help text of guest invitation users/emails input (#3111) * Fixing help text of guest invitation users/emails input * Updating snapshots * Fix confirm back/close behavior in the invitation flow modal (#3108) * Fix confirm back/close behavior in the invitation flow modal * Addressing PR comments * Fixing copy button on invitation flow (#3102) * Fixing copy button * Fixing tests * Small code improvement * Handling redirects on leave channel for guests (#3068) * Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (#3099) * Cypress automated test for "Tutorial - Navigation and Links" (#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (#3087) * Fixing broken permalinks when access directly to the app (#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (#3092) * Listen to route to fix search date filter e2e tests (#3107) * UX screen review fixes for Admin Console Teams/Channels (#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (#3114) * Fixing email invitations disabled problem (#3126) * Fixing email invitations disabled problem * fixing lint * Fixing small errors * Polishing details in invitation flow styles (#3143) * Polishing details in invitation flow styles * Fixing eslint * Adding header warning for guests in channels (#3146) * Adding header warning for guests in channels * Adding i18n strings * Fixing i18n * Updating snapshot * Fixing guest disabled and no license on invitation modal (#3158) * Add invite guest permission to the admin console (#3167) * More style fixes (#3150) * More fixes * Changing a text * Adding beta label to the feature * Updating snapshots * Some more fixes to bugs found by QA (#3184) * Fixing bug on close confirmation * Fixing invite existing guest to a new team * fixing padding on mobile * Reducing the number of requests when is possible * Adding the Guest role to user card in the admin console (#3186) * Updating to the last mattermost-redux version
jespino
added a commit
to jespino/mattermost-webapp
that referenced
this pull request
Jul 22, 2019
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745) * MM-15056: Adding Guest badge to identify guest users * Fixing i18n * Refactoring bot badges to a component (mattermost#2750) * Updating tests * Add permissions checks needed for guest accounts (mattermost#2782) * Add permissions checks needed for guest accounts * Fixing bug * Fixing lint * Add Invitation modal (mattermost#2820) * Add Invitation modal * Adding guest badges to the users in the users_emails input selector * Adding the guest badges where is needed * Fixing small bug showing channel title guest badges * Fixing username formating * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Moving Invite types to constants * Moving formatUserName to utils and renamed * Replacing some FormatedMarkdownMessage with FormattedMessage * Removing empty dialogProps usages * Reusing getDisplayName and getLongDisplayName in users_emails_input component * Error handling on search profiles file * Fixing tests * Removing duplicated import * fixing check styles * Removing unnused i18n strings * Fixing tests * Upgrading the mattermost-redux library * Implementing dark theme for the invitation flow (mattermost#2976) * Implementing dark theme for invitation flow * Fixing some styles * Changes to manage guests (admin console and manage channel and team members) (mattermost#3019) * Changes to manage guests (admin console and manage channel and team members) * Fixing tests * Fixing i18n-check * Fixing tests * Adding guest filtering to the interface * Addressing texts changes proposed by Katie * Upgrading to the last mattermost-redux version * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Fixing translation strings * Updating redux version * First iteration on styling comments for invitation flow (mattermost#3062) * First iteration on styling comments for invitation flow * Fixing i18n * Fixing tests * Adding extra small adjustments * Updating redux version * Administration permissions and guest account settings (mattermost#3039) * Administration permissions and guest account settings * Using constants for permissions * Using constants instead of strings for roles * Adding the proper link icon in the copy link button (mattermost#3104) * Adding the proper link icon in the copy link button * Adding missed i18n string * Allow to go back from confirmation screen (mattermost#3110) * Allow to go back from confirmation screen * Fixing tests * Adding loading spinner to inputs (mattermost#3103) * Fixing help text of guest invitation users/emails input (mattermost#3111) * Fixing help text of guest invitation users/emails input * Updating snapshots * Fix confirm back/close behavior in the invitation flow modal (mattermost#3108) * Fix confirm back/close behavior in the invitation flow modal * Addressing PR comments * Fixing copy button on invitation flow (mattermost#3102) * Fixing copy button * Fixing tests * Small code improvement * Handling redirects on leave channel for guests (mattermost#3068) * Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (mattermost#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (mattermost#3099) * Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (mattermost#3087) * Fixing broken permalinks when access directly to the app (mattermost#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (mattermost#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (mattermost#3092) * Listen to route to fix search date filter e2e tests (mattermost#3107) * UX screen review fixes for Admin Console Teams/Channels (mattermost#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (mattermost#3114) * Fixing email invitations disabled problem (mattermost#3126) * Fixing email invitations disabled problem * fixing lint * Fixing small errors * Polishing details in invitation flow styles (mattermost#3143) * Polishing details in invitation flow styles * Fixing eslint * Adding header warning for guests in channels (mattermost#3146) * Adding header warning for guests in channels * Adding i18n strings * Fixing i18n * Updating snapshot * Fixing guest disabled and no license on invitation modal (mattermost#3158) * Add invite guest permission to the admin console (mattermost#3167) * More style fixes (mattermost#3150) * More fixes * Changing a text * Adding beta label to the feature * Updating snapshots * Some more fixes to bugs found by QA (mattermost#3184) * Fixing bug on close confirmation * Fixing invite existing guest to a new team * fixing padding on mobile * Reducing the number of requests when is possible * Adding the Guest role to user card in the admin console (mattermost#3186) * Updating to the last mattermost-redux version
jespino
added a commit
that referenced
this pull request
Jul 22, 2019
* MM-15056: Adding Guest badge to identify guest users (#2745) * MM-15056: Adding Guest badge to identify guest users * Fixing i18n * Refactoring bot badges to a component (#2750) * Updating tests * Add permissions checks needed for guest accounts (#2782) * Add permissions checks needed for guest accounts * Fixing bug * Fixing lint * Add Invitation modal (#2820) * Add Invitation modal * Adding guest badges to the users in the users_emails input selector * Adding the guest badges where is needed * Fixing small bug showing channel title guest badges * Fixing username formating * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Moving Invite types to constants * Moving formatUserName to utils and renamed * Replacing some FormatedMarkdownMessage with FormattedMessage * Removing empty dialogProps usages * Reusing getDisplayName and getLongDisplayName in users_emails_input component * Error handling on search profiles file * Fixing tests * Removing duplicated import * fixing check styles * Removing unnused i18n strings * Fixing tests * Upgrading the mattermost-redux library * Implementing dark theme for the invitation flow (#2976) * Implementing dark theme for invitation flow * Fixing some styles * Changes to manage guests (admin console and manage channel and team members) (#3019) * Changes to manage guests (admin console and manage channel and team members) * Fixing tests * Fixing i18n-check * Fixing tests * Adding guest filtering to the interface * Addressing texts changes proposed by Katie * Upgrading to the last mattermost-redux version * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Fixing translation strings * Updating redux version * First iteration on styling comments for invitation flow (#3062) * First iteration on styling comments for invitation flow * Fixing i18n * Fixing tests * Adding extra small adjustments * Updating redux version * Administration permissions and guest account settings (#3039) * Administration permissions and guest account settings * Using constants for permissions * Using constants instead of strings for roles * Adding the proper link icon in the copy link button (#3104) * Adding the proper link icon in the copy link button * Adding missed i18n string * Allow to go back from confirmation screen (#3110) * Allow to go back from confirmation screen * Fixing tests * Adding loading spinner to inputs (#3103) * Fixing help text of guest invitation users/emails input (#3111) * Fixing help text of guest invitation users/emails input * Updating snapshots * Fix confirm back/close behavior in the invitation flow modal (#3108) * Fix confirm back/close behavior in the invitation flow modal * Addressing PR comments * Fixing copy button on invitation flow (#3102) * Fixing copy button * Fixing tests * Small code improvement * Handling redirects on leave channel for guests (#3068) * Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (#3099) * Cypress automated test for "Tutorial - Navigation and Links" (#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (#3087) * Fixing broken permalinks when access directly to the app (#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (#3092) * Listen to route to fix search date filter e2e tests (#3107) * UX screen review fixes for Admin Console Teams/Channels (#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (#3114) * Fixing email invitations disabled problem (#3126) * Fixing email invitations disabled problem * fixing lint * Fixing small errors * Polishing details in invitation flow styles (#3143) * Polishing details in invitation flow styles * Fixing eslint * Adding header warning for guests in channels (#3146) * Adding header warning for guests in channels * Adding i18n strings * Fixing i18n * Updating snapshot * Fixing guest disabled and no license on invitation modal (#3158) * Add invite guest permission to the admin console (#3167) * More style fixes (#3150) * More fixes * Changing a text * Adding beta label to the feature * Updating snapshots * Some more fixes to bugs found by QA (#3184) * Fixing bug on close confirmation * Fixing invite existing guest to a new team * fixing padding on mobile * Reducing the number of requests when is possible * Adding the Guest role to user card in the admin console (#3186) * Updating to the last mattermost-redux version
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-16044 - Updating radio buttons (a11y) * Updating test
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745) * MM-15056: Adding Guest badge to identify guest users * Fixing i18n * Refactoring bot badges to a component (mattermost#2750) * Updating tests * Add permissions checks needed for guest accounts (mattermost#2782) * Add permissions checks needed for guest accounts * Fixing bug * Fixing lint * Add Invitation modal (mattermost#2820) * Add Invitation modal * Adding guest badges to the users in the users_emails input selector * Adding the guest badges where is needed * Fixing small bug showing channel title guest badges * Fixing username formating * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Moving Invite types to constants * Moving formatUserName to utils and renamed * Replacing some FormatedMarkdownMessage with FormattedMessage * Removing empty dialogProps usages * Reusing getDisplayName and getLongDisplayName in users_emails_input component * Error handling on search profiles file * Fixing tests * Removing duplicated import * fixing check styles * Removing unnused i18n strings * Fixing tests * Upgrading the mattermost-redux library * Implementing dark theme for the invitation flow (mattermost#2976) * Implementing dark theme for invitation flow * Fixing some styles * Changes to manage guests (admin console and manage channel and team members) (mattermost#3019) * Changes to manage guests (admin console and manage channel and team members) * Fixing tests * Fixing i18n-check * Fixing tests * Adding guest filtering to the interface * Addressing texts changes proposed by Katie * Upgrading to the last mattermost-redux version * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Fixing translation strings * Updating redux version * First iteration on styling comments for invitation flow (mattermost#3062) * First iteration on styling comments for invitation flow * Fixing i18n * Fixing tests * Adding extra small adjustments * Updating redux version * Administration permissions and guest account settings (mattermost#3039) * Administration permissions and guest account settings * Using constants for permissions * Using constants instead of strings for roles * Adding the proper link icon in the copy link button (mattermost#3104) * Adding the proper link icon in the copy link button * Adding missed i18n string * Allow to go back from confirmation screen (mattermost#3110) * Allow to go back from confirmation screen * Fixing tests * Adding loading spinner to inputs (mattermost#3103) * Fixing help text of guest invitation users/emails input (mattermost#3111) * Fixing help text of guest invitation users/emails input * Updating snapshots * Fix confirm back/close behavior in the invitation flow modal (mattermost#3108) * Fix confirm back/close behavior in the invitation flow modal * Addressing PR comments * Fixing copy button on invitation flow (mattermost#3102) * Fixing copy button * Fixing tests * Small code improvement * Handling redirects on leave channel for guests (mattermost#3068) * Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (mattermost#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (mattermost#3099) * Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (mattermost#3087) * Fixing broken permalinks when access directly to the app (mattermost#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (mattermost#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (mattermost#3092) * Listen to route to fix search date filter e2e tests (mattermost#3107) * UX screen review fixes for Admin Console Teams/Channels (mattermost#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (mattermost#3114) * Fixing email invitations disabled problem (mattermost#3126) * Fixing email invitations disabled problem * fixing lint * Fixing small errors * Polishing details in invitation flow styles (mattermost#3143) * Polishing details in invitation flow styles * Fixing eslint * Adding header warning for guests in channels (mattermost#3146) * Adding header warning for guests in channels * Adding i18n strings * Fixing i18n * Updating snapshot * Fixing guest disabled and no license on invitation modal (mattermost#3158) * Add invite guest permission to the admin console (mattermost#3167) * More style fixes (mattermost#3150) * More fixes * Changing a text * Adding beta label to the feature * Updating snapshots * Some more fixes to bugs found by QA (mattermost#3184) * Fixing bug on close confirmation * Fixing invite existing guest to a new team * fixing padding on mobile * Reducing the number of requests when is possible * Adding the Guest role to user card in the admin console (mattermost#3186) * Updating to the last mattermost-redux version
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-16044 - Updating radio buttons (a11y) * Updating test
skheria
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 3, 2019
* MM-15056: Adding Guest badge to identify guest users (mattermost#2745) * MM-15056: Adding Guest badge to identify guest users * Fixing i18n * Refactoring bot badges to a component (mattermost#2750) * Updating tests * Add permissions checks needed for guest accounts (mattermost#2782) * Add permissions checks needed for guest accounts * Fixing bug * Fixing lint * Add Invitation modal (mattermost#2820) * Add Invitation modal * Adding guest badges to the users in the users_emails input selector * Adding the guest badges where is needed * Fixing small bug showing channel title guest badges * Fixing username formating * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Apply suggestions from code review Co-Authored-By: Martin Kraft <[email protected]> * Moving Invite types to constants * Moving formatUserName to utils and renamed * Replacing some FormatedMarkdownMessage with FormattedMessage * Removing empty dialogProps usages * Reusing getDisplayName and getLongDisplayName in users_emails_input component * Error handling on search profiles file * Fixing tests * Removing duplicated import * fixing check styles * Removing unnused i18n strings * Fixing tests * Upgrading the mattermost-redux library * Implementing dark theme for the invitation flow (mattermost#2976) * Implementing dark theme for invitation flow * Fixing some styles * Changes to manage guests (admin console and manage channel and team members) (mattermost#3019) * Changes to manage guests (admin console and manage channel and team members) * Fixing tests * Fixing i18n-check * Fixing tests * Adding guest filtering to the interface * Addressing texts changes proposed by Katie * Upgrading to the last mattermost-redux version * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Update i18n/en.json Co-Authored-By: Miguel de la Cruz <[email protected]> * Fixing translation strings * Updating redux version * First iteration on styling comments for invitation flow (mattermost#3062) * First iteration on styling comments for invitation flow * Fixing i18n * Fixing tests * Adding extra small adjustments * Updating redux version * Administration permissions and guest account settings (mattermost#3039) * Administration permissions and guest account settings * Using constants for permissions * Using constants instead of strings for roles * Adding the proper link icon in the copy link button (mattermost#3104) * Adding the proper link icon in the copy link button * Adding missed i18n string * Allow to go back from confirmation screen (mattermost#3110) * Allow to go back from confirmation screen * Fixing tests * Adding loading spinner to inputs (mattermost#3103) * Fixing help text of guest invitation users/emails input (mattermost#3111) * Fixing help text of guest invitation users/emails input * Updating snapshots * Fix confirm back/close behavior in the invitation flow modal (mattermost#3108) * Fix confirm back/close behavior in the invitation flow modal * Addressing PR comments * Fixing copy button on invitation flow (mattermost#3102) * Fixing copy button * Fixing tests * Small code improvement * Handling redirects on leave channel for guests (mattermost#3068) * Allow to leave default channels if you are a guest * On guests without teams enter show an error message * Fixing channel redirections on leaveChannel guest cases * Fixing i18n * Fixing tests and addressing PR comments * Fixing tests * MM-16044 - Updating radio buttons (a11y) (mattermost#3085) * MM-16044 - Updating radio buttons (a11y) * Updating test * fix flaky test on markdown and teams spec (mattermost#3099) * Cypress automated test for "Tutorial - Navigation and Links" (mattermost#3069) * Added Cypress test for MM-13989 UI Automation: Write an automated test using 'cypress' for "Tutorial - Navigation and Links" Added 2 methods to api commands to create/login new user without turning off the tutorial preference. * Cleaned up ESLINT errors * Cleaned up ESLINT errors * Made requested changes. * Second round of suggestions from Pull Request * Fixed href request * fix unit test and browser JS warning (mattermost#3087) * Fixing broken permalinks when access directly to the app (mattermost#3105) * [MM-16533] User deactivation does not work when "Disable bot accounts when owner is deactivated" is set to False (mattermost#3094) * [MM-16533] fixed a couple bugs; always display deactivateMemberModal * PR comment * Allow to go back from confirmation screen * Fixing tests * [MM-16379] Accessibility Navigation Controller (mattermost#3047) * accessibility controller and related updates # Conflicts: # components/root/root.jsx # components/search_bar/search_bar.jsx # components/sidebar/header/sidebar_header.jsx # components/sidebar/sidebar.jsx * reset navigation following intra region navigation * remove old a11y event constants * update snapshots * check-style updates * add a11y events into rhs posts * update dom references to the preferred method * react components inform conroller when updated * added missing constants * only dispatch update events when a11y active * review update * remove temp console.log’s * fix mouse click visual glitch * change keyboard-focus class to a11y—focused * allow post to receive tab focus * remove exception for posts reset * only apply a11y visual outline when using a11y nav * maintain flag button visual outline on enter * better handling of certain key combinations * fix test issue * disable controller when bootstrap modal is open * handle modals and pop ups * add overide for section navigation looping * remove console.logs * fix Cypress run script (mattermost#3092) * Listen to route to fix search date filter e2e tests (mattermost#3107) * UX screen review fixes for Admin Console Teams/Channels (mattermost#3058) Co-authored-by: Martin Kraft <[email protected]> * MM-16081 - Updating aria label for team buttons (mattermost#3114) * Fixing email invitations disabled problem (mattermost#3126) * Fixing email invitations disabled problem * fixing lint * Fixing small errors * Polishing details in invitation flow styles (mattermost#3143) * Polishing details in invitation flow styles * Fixing eslint * Adding header warning for guests in channels (mattermost#3146) * Adding header warning for guests in channels * Adding i18n strings * Fixing i18n * Updating snapshot * Fixing guest disabled and no license on invitation modal (mattermost#3158) * Add invite guest permission to the admin console (mattermost#3167) * More style fixes (mattermost#3150) * More fixes * Changing a text * Adding beta label to the feature * Updating snapshots * Some more fixes to bugs found by QA (mattermost#3184) * Fixing bug on close confirmation * Fixing invite existing guest to a new team * fixing padding on mobile * Reducing the number of requests when is possible * Adding the Guest role to user card in the admin console (mattermost#3186) * Updating to the last mattermost-redux version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-16044 - Updating radio buttons (a11y)
Ticket Link
https://mattermost.atlassian.net/browse/MM-16044