This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14860 Localization for client plugins. #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @hanzei FYI |
levb
approved these changes
Apr 5, 2019
| if (this.props.location.pathname === '/' && this.props.noAccounts) { | ||
| this.props.history.push('/signup_user_complete'); | ||
| } | ||
|
|
||
| this.setState({configLoaded: true}); | ||
| initializePlugins().then(() => { |
There was a problem hiding this comment.
Just so I understand, is this just cleanup and not directly relevant, or is this so that we now wait until all translations are loaded inside initializePlugin()?
There was a problem hiding this comment.
We now wait for all plugins to be loaded.
jwilander
approved these changes
Apr 8, 2019
hmhealey
approved these changes
Apr 9, 2019
| import {ActionTypes} from 'utils/constants.jsx'; | ||
|
|
||
| function translations(state = {en}, action) { | ||
| function translations(state = {}, action) { |
There was a problem hiding this comment.
I don't think the change in when the English translations are added should make a difference, but any idea of we might be using those translations before loadTranslations has been called?
There was a problem hiding this comment.
As far as I can tell we can't use the translations system before that point, so if there are instances, they don't work anyway.
hanzei
added
4: Reviews Complete
lindy65
added
Tests/Not Needed
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a functional, ready to merge, proposal on how webapp side plugin translation could work.
The basic process from the plugin side is to use the new
PluginRegistery.registerTranslationsfunction to register a callback of the formgetTranslations(locale)that delivers translations on demand. The plugin is then responsible for providing translations for English, and every language it supports. How to get those translations and if Mattermost the company gets involved is out of the scope of this PR, but it assumes the translation files will live with the plugins.One consequence of not of this method is to avoid the translations causing a "screen flash" when they load in, webapp plugin loading has been made synchronous with the rendering of the root component. ie. The root component will not render until all plugins have performed their initialization. This both solves the problem for translations and prevents plugins from popping in later. However it does raise the possibility of long plugin initialization slowing down the initial load of the webapp.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14860
Related Pull Requests
Demo plugin using this: mattermost/mattermost-plugin-demo#25