Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-14860 Adding localization. #25

Merged
merged 2 commits into from
Apr 9, 2019
Merged

MM-14860 Adding localization. #25

merged 2 commits into from
Apr 9, 2019

Conversation

crspeller
Copy link
Member

@crspeller crspeller commented Apr 5, 2019 •
edited
Loading

@crspeller crspeller mentioned this pull request Apr 5, 2019
Merged
@crspeller crspeller added the 2: Dev Review Requires review by a core committer label Apr 5, 2019
@crspeller crspeller marked this pull request as ready for review April 5, 2019 20:03
levb
levb approved these changes Apr 5, 2019
View reviewed changes
webapp/src/plugin.jsx Outdated Show resolved Hide resolved
hanzei
hanzei reviewed Apr 6, 2019
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two general comments, as I can't provide much feedback on the react part.

webapp/src/components/left_sidebar_header/left_sidebar_header.jsx Show resolved Hide resolved
Makefile Show resolved Hide resolved
jwilander
jwilander approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the existing comments by others

@crspeller
Copy link
Member Author

@hanzei Ready for re-review.

@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 8, 2019
@levb
Copy link
Contributor

levb commented Apr 8, 2019

Is this ready to merge, or are we waiting on other PRs?

@crspeller crspeller added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Apr 8, 2019
@crspeller
Copy link
Member Author

Waiting on the base PR.

@crspeller crspeller merged commit 74756b3 into master Apr 9, 2019
@crspeller crspeller deleted the mm-14860 branch April 9, 2019 18:36
@hanzei hanzei removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@levb levb levb approved these changes

@jwilander jwilander jwilander approved these changes

@hmhealey hmhealey Awaiting requested review from hmhealey

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crspeller @levb @jwilander @hanzei