Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14873 Add Cypress API command to create and delete a team and channel #2601

Merged
merged 3 commits into from
Apr 4, 2019
Merged

MM-14873 Add Cypress API command to create and delete a team and channel #2601

merged 3 commits into from
Apr 4, 2019

Conversation

saturninoabril
Copy link
Member

Summary

Add API commands to create and delete a team and channel.

This fixes the issue at channel_switcher_spec where it sometimes failed when a hardcoded channel is not present in the initial sample data. So such spec is done by creating a channel on pre-setup.

This is submitted on top of #2600. Particular commit of this PR is at 633373e.

Ticket Link

Jira ticket: MM-14873

Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR was done on top of the other one, right?

@saturninoabril
Copy link
Member Author

Yes, it is. I also mentioned in the ticket, will rebase once the other gets merged.

Copy link
Collaborator

@cometkim cometkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make every api commands return thenable to be chained with others would be more useful.

cypress/support/api_commands.js Outdated Show resolved Hide resolved
cypress/support/api_commands.js Outdated Show resolved Hide resolved
cypress/support/api_commands.js Outdated Show resolved Hide resolved
cypress/support/api_commands.js Outdated Show resolved Hide resolved
@saturninoabril
Copy link
Member Author

We don't have test that requires for it at the moment but we'll definitely have in the future. So I update those per your comments, thanks @cometkim.

@saturninoabril saturninoabril merged commit beab720 into mattermost:master Apr 4, 2019
@saturninoabril saturninoabril deleted the MM-14873 branch April 4, 2019 08:13
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Apr 13, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation and removed Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 16, 2019
@jasonblais
Copy link
Contributor

@saturninoabril Confirming this change is only for Cypress end-to-end testing, not anything a developer/user/admin would use directly with Mattermost?

@jasonblais jasonblais self-assigned this Jun 3, 2019
@saturninoabril saturninoabril changed the title MM-14873 Add API command to create and delete a team and channel MM-14873 Add Cypress API command to create and delete a team and channel Jun 3, 2019
@saturninoabril
Copy link
Member Author

@jasonblais Yes, this is only for Cypress end-to-end testing.

@jasonblais jasonblais added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Jun 3, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry and removed Changelog/Done Required changelog entry has been written labels Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
6 participants