This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14391 Reorganize command to reset account settings via API and separate API and UI commands #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
commented
Apr 3, 2019
| // * Verify that the width is at 1123px | ||
| cy.get('.post__content').last().should('have.css', 'width', '1123px'); | ||
| // * Verify that the width is at 1131px | ||
| cy.get('.post__content').last().should('have.css', 'width', '1131px'); |
There was a problem hiding this comment.
Not related but fix anyway. I'm not particularly sure what has changed but there might be a bit of change in styles recently.
There was a problem hiding this comment.
hmm, should we change this to use closeTo assertion instead of exact comparison?
There was a problem hiding this comment.
What I did is just compare the exact classname to #postContent. Please take a look again. Also in the latest commit, I removed the unnecessary test.
There was a problem hiding this comment.
It looks much better now 👍
saturninoabril
changed the title
…I and UI commands
enahum
approved these changes
Apr 3, 2019
cometkim
approved these changes
Apr 3, 2019
amyblais
added
Changelog/Not Needed
codearth01
pushed a commit
to codearth01/mattermost-webapp
that referenced
this pull request
Sep 9, 2019
…arate API and UI commands (mattermost#2600) * reorganize command to reset account settings via API and separated API and UI commands * replaced pixel value with CSS class validation, and removed unnecessary test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reorganized command to reset account settings via API
Use
cy.apiSaveUserPreference()to update/save account settings by passingpreferenceto be saved.Separated API and UI commands
Intention is to easily identify and properly choose which one is appropriate in a spec file. I foresee the implementation as follow:
Name format and function signature:
apiand follows the signature of required parameters at https://api.mattermost.com/To follow: will update E2E documentation to reflect this info.
Ticket Link
Jira - MM-14391