[MM-12396] Option to add user to a channel from the profile pop-over

[mickmister]

Summary

This is an added option to the profile pop-over to add another user to a different channel.

The components/profile_popover component is affected, and a new modal components/add_user_to_channel_modal has been introduced.

GitHub Issue Link

mattermost/mattermost#9501

Ticket Link

https://mattermost.atlassian.net/browse/MM-12396

Invision screens: https://invis.io/DYNZR9J64A9

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Ran make check-style to check for style errors (required for all pull requests)
• Ran make test to ensure unit and component tests passed
• Added or updated unit tests (required for all new features)
• Has UI changes
• Includes text changes and localization file (.../i18n/en.json) updates

[esethna]

Thanks @mickmister! I wasn't able to test the PR as it seems there is a build failure. Please help look into this when you have a chance and we can set up a test server. Regarding your questions:

1. Re Permissions: Adding @grundleborg who is familiar with that area to provide some guidance on permissions checks.

2. Re Styling: Looks fine to me, since it's consistent with other modals in the product. Once the test server is up I'll test the selector component.

3. Re Testing the suggestion provider and import issues in tests: Adding @saturninoabril who can provide some guidance in that area.

[mickmister]

https://pre-release.mattermost.com/core/pl/ssdwfa5z53bdpjbqns3yyc4cty
There was a mention that a refactoring may be in the works for providers to be connected to the redux store. If this is the case, I'll fix my code/tests accordingly when it is resolved.

[saturninoabril]

@mickmister Thanks for your contribution! I pulled out your branch and it's really weird that it's having that issue. I'll find time to see what's going on there.
But I guess it's right to wait till that on going refactor is completed.

[saturninoabril]

@mickmister There's an initial change on SuggestionStore - https://github.com/mattermost/mattermost-webapp/pull/1932/files. Once merged, could you please try again and see if you're still having issue in importing the test. Thanks!

[mickmister]

Awesome, will do!

[grundleborg]

On the permissions question: you can use haveITeamPermission or haveICurrentTeamPermission to manage team-scoped permissions. If it's managing the channel though, you should use haveIChannelPermission instead.

However, you can go one better even than this. Instead of passing in a prop for this, you can use the <ChannelPermissionGate> component in the render function around the JSX elements that you want to depend on that permission. This is the preferred way to do permissions wherever possible. If you grep the source code for the relevant permissions gate component, you'll find many examples of how to use it.

[mickmister]

Using ChannelPermissionGate is the better solution here. My intent was to keep the component as dumb as possible, but that doesn't mean that it shouldn't be doing the permission assertions. Passing a simple boolean to the component makes it easy to test (no permission setup required in the test), but the component isn't tested properly at that point. Using ChannelPermissionGate ends up with much cleaner code. Thank you for your feedback!

[mickmister]

@saturninoabril

Once merged, could you please try again and see if you're still having issue in importing the test.

The import issue isn't happening anymore :)

There's an initial change on SuggestionStore - https://github.com/mattermost/mattermost-webapp/pull/1932/files.

I have my branch updated with the changes from the above PR. The Suggestion components are still using the global getState, so I think this PR is still on hold. Unless we want to proceed without connecting the component to redux.

[saturninoabril]

Thanks @mickmister! For me, that on going efforts on redux migration is non-blocking for this PR. I'm good with how it's done right now. Let us know if PR is complete so we can proceed with the PM review. Thanks!

[esethna]

@mickmister please let me know when this is ready to test, looking forward to it!

[mickmister]

@saturninoabril recent pushes address all of your requested changes

[mickmister]

@esethna PR is ready barring any further requested changes.

[mickmister]

Awesome, thanks @saturninoabril!

[mickmister]

@hanzei There was an issue with this PR so it got reverted. I am working on a new PR for the fix. Should this issue be reopened or should a new issue be created?

[hanzei]

Would you just open a new PR for this and I will reopen mattermost/mattermost#9501?

[mickmister]

Yes, thank you @hanzei