[Help Wanted] [MM-12396] Option to add user to a channel from the profile pop-over

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

This is an added option to the profile pop-over to add another user to a different channel.

Invision screens: https://invis.io/DYNZR9J64A9

Notes:

• Only the users who have permissions to manage channel members will be able to see this option.

  • If the user has manage channel member permissions for public OR private channels, show the option in the profile pop-over
  • If the user has only manage channel member permissions for public channels, then show the option in the profile pop-over and only show public channels in the channel dropdown.
  • If the user has only manage channel member permissions for private channels, then show the option in the profile pop-over and only show private channels in the channel dropdown.

• Users can only add other users to channels they already belong to. (The list shows only the channels the user is in).

• If a user tries to add a person to a channel he is already in, there is an error as soon as he selects that channel from the list.

• After a user adds someone to a channel, a system message of the user being added to that channel is posted in the channel in which he was added in.

• The user who is doing the adding is returned to his previous state after clicking “Add” and the modal closes.

[mickmister]

I'd like to work on this. I couldn't find a modal that already does this action, so I've taken some time looking at how modals are spawned and how their state is maintained, as well as how some modals may be re-used for slightly different purposes. I'll be asking questions on some of these details on the dev chat as I continue to work on the feature.

As far as the feature is concerned, is this something that will be included in the mobile app as well?

[mickmister]

In the Invision design included above, the channel picker is a drop down select box. All channel pickers I've seen in the app have been standard text boxes that show results below in a drop down fashion as the user types. I think that same functionality would be re-used in this case, but I wanted to clarify since the design shows a different component being used for the selection.

[jasonblais]

Thanks @mickmister! Good questions. @esethna / @asaadmahmood would you be able to help with the above?

[esethna]

Yes thanks @mickmister, makes sense, we can use a similar component as used in the channel switcher. However the difference being the user doing the adding should have to click "Add" in the modal. Where as the channel switcher disappears as soon as you select a channel from the list. Let us know if you have any other questions, I'll remove the "up for grabs" label :)

Also, this feature is webapp only for now

[hanzei]

Fixed with mattermost/mattermost-webapp#1918

[hanzei]

Reopened, as mattermost/mattermost-webapp#1918 got reverted. @mickmister is working on a new PR.

[mickmister]

@hanzei I am unable to reproduce the issues laid out in the Jira ticket comments. I've followed up on the ticket accordingly, asking for further explanation of how to reproduce.

[hanzei]

Hey @mickmister, thanks for keeping track of this!

@lindy65 could you please share some details on what exactly the permission issue is and how to repo it?

[lindy65]

Thanks @hanzei @mickmister

I am going to retest this feature on master and will comment in the Jira ticket in response to @mickmister's questions/comments.

[jespino]

Fixed by #2435 and #806