Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update markdown.jsx #16

Closed
wants to merge 1 commit into from
Closed

Update markdown.jsx #16

wants to merge 1 commit into from

Conversation

prixone
Copy link
Contributor

@prixone prixone commented Sep 8, 2017

Summary

Should not add http:https:// if the first part have numbers:

uri1:test or [test link](uri1:test)

Ticket Link

mattermost/mattermost#7405

Checklist

  • Minor change

Should not add http:https:// if the first part have numbers:

``uri1:test``
@esethna esethna self-assigned this Sep 11, 2017
@esethna
Copy link
Contributor

esethna commented Sep 11, 2017

Thanks @prixone! We are working on getting test servers up and running on this repo, once that happens we'll be able to test and finish reviewing this PR.

@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Sep 26, 2017
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: http:https://i-095c8a49f970f48fd.spinmint.com:8065/pr16

Test Account 1: Email: [email protected] | Password: passwd

Test Account 2: Email: [email protected] | Password: passwd

Instance ID: i-095c8a49f970f48fd

Copy link
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prixone! Looks good.

@esethna esethna added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Sep 28, 2017
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@esethna esethna removed their assignment Sep 28, 2017
@jasonblais jasonblais added this to the v4.3.0 milestone Sep 29, 2017
@ccbrown
Copy link
Contributor

ccbrown commented Oct 3, 2017

@prixone Can you rebase this?

@esethna esethna modified the milestones: v4.3.0, v4.4.0 Oct 4, 2017
@ryantm
Copy link
Contributor

ryantm commented Oct 9, 2017

@ccbrown @esethna Is this getting bumped to 4.4.0 because of lack of rebase? I can resubmit the PR if that's why.

@ccbrown
Copy link
Contributor

ccbrown commented Oct 10, 2017

@ryantm 4.3 RC1 was already cut, but if you want to rebase this against the release-4.3 branch, I think we can still get it merged in time for 4.3.

@ryantm
Copy link
Contributor

ryantm commented Oct 10, 2017

@ccbrown Okay. Done in #135

@ccbrown
Copy link
Contributor

ccbrown commented Oct 11, 2017

Merged in #135.

@ccbrown ccbrown closed this Oct 11, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Oct 16, 2017
chetanyakan referenced this pull request in brightscout-alpha/mattermost-webapp May 14, 2019
Replaced WebRTC button with video chat icon
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
Move channel and team actions to APIv4
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
Move channel and team actions to APIv4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Tests/Not Needed Does not require new release tests
Projects
None yet
10 participants