Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update markdown.jsx for numbers in uris #135

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

ryantm
Copy link
Contributor

@ryantm ryantm commented Oct 10, 2017

Rebasing #16 on top of release-4.3.

Should not add http:https:// if the first part have numbers:

uri1:test

cc @ccbrown

Should not add http:https:// if the first part have numbers:

``uri1:test``
@mattermod
Copy link
Contributor

Thanks @ryantm for the pull request!

Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?

This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@ryantm ryantm mentioned this pull request Oct 10, 2017
1 task
@ryantm
Copy link
Contributor Author

ryantm commented Oct 10, 2017

I signed the CLA.

@enahum enahum requested a review from hmhealey October 10, 2017 12:05
@jwilander jwilander added the 2: Dev Review Requires review by a core commiter label Oct 10, 2017
@jwilander jwilander added this to the v4.3.0 milestone Oct 10, 2017
@ccbrown ccbrown merged commit f4c2a2a into mattermost:release-4.3 Oct 10, 2017
@ccbrown
Copy link
Contributor

ccbrown commented Oct 10, 2017

Thanks!

@ryantm ryantm deleted the number-uri branch October 10, 2017 16:34
@ryantm ryantm restored the number-uri branch October 10, 2017 16:35
@ryantm ryantm deleted the number-uri branch October 10, 2017 16:35
ryantm added a commit to ryantm/mattermost-webapp that referenced this pull request Oct 10, 2017
Should not add http:https:// if the first part have numbers:

``uri1:test``
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Oct 16, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
9 participants