Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-10844: maximum file size is a TYPE_NUMBER #1310

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

lieut-data
Copy link
Member

Summary

Maximum file size is a TYPE_NUMBER.

Ticket Link

https://mattermost.atlassian.net/browse/MM-10844

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@lieut-data lieut-data added the 2: Dev Review Requires review by a core commiter label Jun 8, 2018
@lieut-data lieut-data added this to the v5.0.0 milestone Jun 8, 2018
@crspeller crspeller added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jun 11, 2018
@cpanato cpanato merged commit 97a2a9e into release-5.0 Jun 11, 2018
@cpanato cpanato deleted the mm-10844-fix-saving-maximum-file-size-setting branch June 11, 2018 14:55
cpanato added a commit that referenced this pull request Jun 11, 2018
* MM-10762: Adjusts team and channel role changes to support new permissions schemes. (#1293)

* Adds next Redux commit. (#1294)

* MM-10793: Handle the show/hide custom emojis in menu using permissions (#1290)

* fix missing users' status indicators on more DM modal (#1279)

* MM-10772 - Updating permissions changes (#1284)

* MM-10772 - Updating permissions changes

* Updating permissions stuff

* Updating button spacing

* Updating team icons

* Updating test snapshots

* Minor 5.0 Bug fixes (#1289)

* MM-10733 - Updating UI for posts

* MM-10780 - Updating emoji reaction tooltip

* MM-10713 Fixed collapsed post colour in permalink view (#1291)

* MM-10602 Removed extra space from OpenGraph preview for links without a description (#1276)

* MM-10602 Removed extra space from OpenGraph preview for links without a description

* Removed unnecessary div

* MM-10767: Sort the teams in the teams selector modal (#1299)

* translations PR 20180604 (#1286)

* Fix typo (platform --> mattermost) (#1300)

* MM-10555 Update outgoing webhook content-type help text (#1287)

* Update outgoing webhook content-type help text

* Update styling

* More text updates

* fix permission error on channel_converted event (#1301)

* Minor 5.0 bugs (#1296)

* MM-10795 - Fixing post control menu overlap

* Updaing post control hover

* MM-10798 - Fixing notification badge on t-sidebar

* MM-10789: propagate post channel_mentions to Markdown (#1304)

The `post.props.channel_mentions` structure sent by the server needed to
be passed to the Markdown component to allow merging with the already
known channels for linking.

* Fix color settings in the admin console and announcement setting disabling (#1309)

* Minor 5.0 Bug fixes (#1305)

* MM-10811 - Fixing overflow on long posts

* Removing overflow from post-message

* Updating thread view

* MM-10848 - Updating username line-height

* MM-10806: Fix for no search highlighting. (#1307)

* MM-10806: Fix for no search highlighting.

* MM-10806: Changes options.

* MM-10844: maximum file size is a TYPE_NUMBER (#1310)
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 11, 2018
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Jun 13, 2018
hmhealey added a commit that referenced this pull request Mar 17, 2021
* Fix removal of current channel from autoclosing DM logic

* Fix linter

* change variable name

* [MM-27927] - Add user preference for limit on dms and gms (#1300)

* [MM-27927] - Add user preference for limit on dms and gms

* Fix failing tests

* fix wrong preference naming

* Add tests and fix selector

* Resolve PR comments

* Fix tests

* call limit pref directly

Co-authored-by: Nevyana Angelova <[email protected]>
Co-authored-by: Nevyana Angelova <[email protected]>

* Always add current channel to the list

* update test case to be more reliable

* fix display of new messages

* remove redundant check

* Limit based on last unread inde#x

* update test

* introduce sorting by unreads and last_viewed_at

* Update src/selectors/entities/channel_categories.ts

Co-authored-by: Harrison Healey <[email protected]>

* PR changes

* fix latest bugs

* remove check for last viewed at

* add default value for limit pref

* Filter first manually closed dms

* bring back check for last viewed at

* Maintain channel order when passed into filterAutoclosedDMs

Co-authored-by: Nevyana Angelova <[email protected]>
Co-authored-by: Nevyana Angelova <[email protected]>
Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Harrison Healey <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants