This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Minor 5.0 Bug fixes #1305
Merged
Minor 5.0 Bug fixes #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
approved these changes
Jun 8, 2018
|
Having the username on top seems fine. I'm pretty sure it worked that way prior to the collapsed post changes anyway |
|
Spinmint test server created at: https://i-0a470d0e4de5718ce.test.spinmint.com Test Admin Account: Username: Test User Account: Username: Instance ID: i-0a470d0e4de5718ce |
jwilander
approved these changes
Jun 11, 2018
hmhealey
suggested changes
Jun 11, 2018
hmhealey
approved these changes
Jun 11, 2018
cpanato
added a commit
that referenced
this pull request
Jun 11, 2018
* MM-10762: Adjusts team and channel role changes to support new permissions schemes. (#1293) * Adds next Redux commit. (#1294) * MM-10793: Handle the show/hide custom emojis in menu using permissions (#1290) * fix missing users' status indicators on more DM modal (#1279) * MM-10772 - Updating permissions changes (#1284) * MM-10772 - Updating permissions changes * Updating permissions stuff * Updating button spacing * Updating team icons * Updating test snapshots * Minor 5.0 Bug fixes (#1289) * MM-10733 - Updating UI for posts * MM-10780 - Updating emoji reaction tooltip * MM-10713 Fixed collapsed post colour in permalink view (#1291) * MM-10602 Removed extra space from OpenGraph preview for links without a description (#1276) * MM-10602 Removed extra space from OpenGraph preview for links without a description * Removed unnecessary div * MM-10767: Sort the teams in the teams selector modal (#1299) * translations PR 20180604 (#1286) * Fix typo (platform --> mattermost) (#1300) * MM-10555 Update outgoing webhook content-type help text (#1287) * Update outgoing webhook content-type help text * Update styling * More text updates * fix permission error on channel_converted event (#1301) * Minor 5.0 bugs (#1296) * MM-10795 - Fixing post control menu overlap * Updaing post control hover * MM-10798 - Fixing notification badge on t-sidebar * MM-10789: propagate post channel_mentions to Markdown (#1304) The `post.props.channel_mentions` structure sent by the server needed to be passed to the Markdown component to allow merging with the already known channels for linking. * Fix color settings in the admin console and announcement setting disabling (#1309) * Minor 5.0 Bug fixes (#1305) * MM-10811 - Fixing overflow on long posts * Removing overflow from post-message * Updating thread view * MM-10848 - Updating username line-height * MM-10806: Fix for no search highlighting. (#1307) * MM-10806: Fix for no search highlighting. * MM-10806: Changes options. * MM-10844: maximum file size is a TYPE_NUMBER (#1310)
|
Spinmint test running for more than 7 days. This test server was terminated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-10811 - Fixing overflow on long posts
MM-10848 - Updating username line-height
Ticket Link
https://mattermost.atlassian.net/browse/MM-10832
https://mattermost.atlassian.net/browse/MM-10848
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed@hmhealey I previously had an overflow hidden on
.post__content, and thought that would fix the issue with the long post stuff. However, that does not work, since it then does not allow the post control dropdown to overflow.I have been trying to figure out a bunch of hacky ways to fix it, but couldn't come up with any. Overflows won't work as the post control dropdown is inside the header, and overflowing anything above the header would also cut the dropdown.
So the most viable fix in my opinion was to have the name appear on the top for long posts on compact view. Seeing as we are this close to release, we don't have much time to refractor the code in a way to make this work as expected.
CC: @esethna.