Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update Image preview setting label and help text #1265

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Update Image preview setting label and help text #1265

merged 3 commits into from
Jun 5, 2018

Conversation

esethna
Copy link
Contributor

@esethna esethna commented May 29, 2018

Update help text and setting label as it applies to image thumbnails as well. From PR:

#1060

@esethna esethna added this to the v5.0.0 milestone May 29, 2018
@esethna esethna added the 2: Dev Review Requires review by a core commiter label May 29, 2018
saturninoabril
saturninoabril approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just need to update test snapshots to make the build successful. You may run npm test -- -u, and then commit the new snapshots.

lieut-data
lieut-data approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @esethna, do you need help with the updates required above?

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jun 5, 2018
@cpanato cpanato closed this Jun 5, 2018
@cpanato cpanato reopened this Jun 5, 2018
@cpanato
Copy link
Contributor

cpanato commented Jun 5, 2018

@esethna can you please rebase?

@cpanato cpanato merged commit f498917 into master Jun 5, 2018
@cpanato cpanato deleted the image-previews branch June 5, 2018 18:17
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 5, 2018
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.0.0
6 participants
@esethna @cpanato @lieut-data @saturninoabril @lindalumitchell @amyblais