Collapse uploaded image #1060

lisakycho · 2018-04-06T05:35:19Z

Summary

Added a feature to allow the image uploaded to be collapsed using an icon and using /collapse command

Ticket Link

N/A

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Ran make check-style to check for style errors (required for all pull requests)
Has UI changes

Screenshots

Left: Image is collapsed

jwilander · 2018-04-06T20:41:47Z

@lfbrock asked @lisakycho to work on this without a ticket

lfbrock · 2018-04-06T21:16:22Z

Thanks @jwilander, @esethna we had some customers requesting this one after the image thumbnail changes were shipped, would you be able to help out with reviewing the UX for it when you have a chance?

esethna

Thanks Lisa! A few comments:

I think all image attachments should be expanded by default after they post (currently they are following the account setting for "Default appearance of image link previews"). Then after post they can follow the /collapse /expand.
Looks like the button to collapse/expand isn't working in some cases:

lisakycho · 2018-04-12T00:54:38Z

@esethna Do you mind letting me know the cases that didn't work for you? Thanks!

esethna · 2018-04-12T15:28:24Z

@lisakycho having trouble identifying the exact repro, but I can repro occasionally if:

Set Account setting Default appearance of image link previews to "Expanded"
Create a new private channel
Paste a single image
Try to click the collapse icon - nothing happens

esethna · 2018-04-18T18:44:01Z

@lisakycho let me know if you are still having trouble reproing and we can try to narrow it down further

lisakycho · 2018-04-18T18:57:21Z

@esethna sorry, i was super busy finishing final exams, i will work on this soon!

lisakycho · 2018-04-19T21:59:06Z

@esethna, I'm having some problem reproing it. Do you mind helping me narrow it down? Also what did you want to do with the ticket if we can't repro it?

esethna · 2018-04-20T21:46:11Z

That's strange, I can repro quite consistently by pasting an image from the clipboard, posting and trying to click the arrows.

@lindalumitchell if you would have a chance to try this PR and let us know if you can identify any issues with the collapse/expand arrows using the mouse?

lisakycho · 2018-04-21T00:01:22Z

Hey @esethna, I pushed a new version of the code where all uploaded images are expanded by default. I’ll keep testing to see if I can find cases where the collapse button does not work.

mattermod · 2018-05-04T22:56:32Z

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

mattermod · 2018-05-04T22:59:05Z

Spinmint test server created at: http:https://i-03863fdacc82e0252.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-03863fdacc82e0252

mattermod · 2018-05-04T23:03:38Z

Spinmint test server destroyed

esethna

@lisakycho nice work solving that issue! Looks great. Moving to dev review.

saturninoabril

Thanks @lisakycho! Just a few comments.

saturninoabril · 2018-05-07T08:26:56Z

components/single_image_view/single_image_view.jsx

 };

 static defaultProps = {
 fileInfo: {},
+ previewEnabled: false,


Is this necessary?

saturninoabril · 2018-05-07T08:30:59Z

components/single_image_view/single_image_view.jsx

+ <a
+ key='toggle'
+ className='post__embed-visibility'
+ data-expanded={this.props.isEmbedVisible}


Is data-expanded needed?

settings. Clean code for collapsing uploaded images. Collapse icon is on the same line as image name. Image uploaded can be collapsed using icon.

… image is loaded.

lisakycho · 2018-05-07T17:12:06Z

Hey, @saturninoabril! Made the changes you requested! Please let me know if there is anything else!

saturninoabril

Cool, thanks!

* add roles constants * update export roles * create roles type * update roles type

jwilander self-assigned this Apr 6, 2018

jwilander added the Work in Progress Not yet ready for review label Apr 6, 2018

jwilander added 1: PM Review Requires review by a product manager and removed Work in Progress Not yet ready for review labels Apr 6, 2018

jwilander requested a review from jasonblais April 6, 2018 20:44

jwilander removed their assignment Apr 6, 2018

jasonblais assigned esethna Apr 6, 2018

lisakycho force-pushed the collapseUploadedImage branch 2 times, most recently from 4275718 to 3e5ba6c Compare April 6, 2018 23:53

esethna added the Setup Old Test Server Triggers the creation of a test server label Apr 11, 2018

esethna suggested changes Apr 11, 2018

View reviewed changes

esethna added the Awaiting Submitter Action Blocked on the author label Apr 11, 2018

lisakycho force-pushed the collapseUploadedImage branch from 3e5ba6c to 5228315 Compare April 19, 2018 03:39

esethna removed Awaiting Submitter Action Blocked on the author Setup Old Test Server Triggers the creation of a test server labels Apr 20, 2018

mattermost deleted a comment from mattermod Apr 20, 2018

esethna added the Setup Old Test Server Triggers the creation of a test server label Apr 20, 2018

esethna assigned lindalumitchell Apr 20, 2018

lisakycho force-pushed the collapseUploadedImage branch from b2084e9 to 3706f35 Compare April 20, 2018 23:26

mattermost deleted a comment from mattermod May 4, 2018

esethna added the Setup Old Test Server Triggers the creation of a test server label May 4, 2018

esethna added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels May 4, 2018

esethna approved these changes May 4, 2018

View reviewed changes

esethna unassigned esethna and lindalumitchell May 4, 2018

saturninoabril suggested changes May 7, 2018

View reviewed changes

lisakycho added 3 commits May 7, 2018 10:38

Uploaded image can collapse like linked images and follows the display

4818eea

settings. Clean code for collapsing uploaded images. Collapse icon is on the same line as image name. Image uploaded can be collapsed using icon.

When images are default to collapse, the page doesn't "jump" when new…

ca1b350

… image is loaded.

Removed unneeded text.

4bd11ef

lisakycho force-pushed the collapseUploadedImage branch from 2f1b36b to 4bd11ef Compare May 7, 2018 16:39

saturninoabril approved these changes May 7, 2018

View reviewed changes

saturninoabril requested a review from jwilander May 7, 2018 18:23

jwilander approved these changes May 9, 2018

View reviewed changes

jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 9, 2018

jwilander merged commit ff15a76 into mattermost:master May 9, 2018

amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 19, 2018

esethna mentioned this pull request May 29, 2018

Update Image preview setting label and help text #1265

Merged

lindalumitchell added the Tests/Done Release tests have been written label Jun 13, 2018

hmhealey pushed a commit that referenced this pull request Aug 28, 2020

[MM-22276] Add roles constants (#1060)

a8aa2b4

* add roles constants * update export roles * create roles type * update roles type

hmhealey pushed a commit that referenced this pull request Mar 17, 2021

[MM-22276] Add roles constants (#1060)

f93771b

* add roles constants * update export roles * create roles type * update roles type

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Collapse uploaded image #1060

Collapse uploaded image #1060

lisakycho commented Apr 6, 2018

jwilander commented Apr 6, 2018

lfbrock commented Apr 6, 2018

esethna left a comment

lisakycho commented Apr 12, 2018

esethna commented Apr 12, 2018

esethna commented Apr 18, 2018

lisakycho commented Apr 18, 2018

lisakycho commented Apr 19, 2018

esethna commented Apr 20, 2018

lisakycho commented Apr 21, 2018

mattermod commented May 4, 2018

mattermod commented May 4, 2018

mattermod commented May 4, 2018

esethna left a comment

saturninoabril left a comment

saturninoabril May 7, 2018

saturninoabril May 7, 2018

lisakycho commented May 7, 2018

saturninoabril left a comment

Collapse uploaded image #1060

Collapse uploaded image #1060

Conversation

lisakycho commented Apr 6, 2018

Summary

Ticket Link

Checklist

Screenshots

jwilander commented Apr 6, 2018

lfbrock commented Apr 6, 2018

esethna left a comment

Choose a reason for hiding this comment

lisakycho commented Apr 12, 2018

esethna commented Apr 12, 2018

esethna commented Apr 18, 2018

lisakycho commented Apr 18, 2018

lisakycho commented Apr 19, 2018

esethna commented Apr 20, 2018

lisakycho commented Apr 21, 2018

mattermod commented May 4, 2018

mattermod commented May 4, 2018

mattermod commented May 4, 2018

esethna left a comment

Choose a reason for hiding this comment

saturninoabril left a comment

Choose a reason for hiding this comment

saturninoabril May 7, 2018

Choose a reason for hiding this comment

saturninoabril May 7, 2018

Choose a reason for hiding this comment

lisakycho commented May 7, 2018

saturninoabril left a comment

Choose a reason for hiding this comment