Assorted Desktop App repo fixes

.eslintignore

@@ -1,3 +1,4 @@
 node_modules
 dist
-api-types/lib
+api-types/lib
+mochawesome-report

.eslintrc.json

@@ -29,6 +29,7 @@
  "react/no-find-dom-node": 2,
  "no-underscore-dangle": ["warn"],
  "@mattermost/use-external-link": 0,
+ "linebreak-style": 0,
  "import/order": [
  2,
  {

.github/actions/test/action.yaml

@@ -11,6 +11,9 @@ inputs:
 runs:
  using: "composite"
  steps:
+ - name: ci/run-eslint
+ run: npm run lint:js-quiet
+ shell: ${{ inputs.shell }}
  - name: ci/run-check-types
  run: npm run check-types
  shell: ${{ inputs.shell }}

scripts/beforepack.js

@@ -1,14 +1,14 @@
 // Copyright (c) 2016-present Mattermost, Inc. All Rights Reserved.
 // See LICENSE.txt for license information.
 
-var fs = require('fs');
-var path = require('path');
+const fs = require('fs');
+const path = require('path');
 
 exports.default = async function beforePack(context) {
  // The debian packager (fpm) complains when the directory to output the package to doesn't exist
  // So we have to manually create it first
- var dir = path.join(context.outDir, context.packager.appInfo.version)
- if (!fs.existsSync(dir)){
+ const dir = path.join(context.outDir, context.packager.appInfo.version);
+ if (!fs.existsSync(dir)) {
  fs.mkdirSync(dir, {recursive: true});
  }
 };

scripts/cp_msi_app_update.js

@@ -3,4 +3,4 @@
 
 const fs = require('fs');
 fs.copyFileSync('release/win-unpacked/resources/app-update.yml', 'release/msi-app-update.yml');
-fs.unlinkSync('release/win-unpacked/resources/app-update.yml');
+fs.unlinkSync('release/win-unpacked/resources/app-update.yml');