Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Desktop App repo fixes #3065

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Assorted Desktop App repo fixes #3065

merged 6 commits into from
Jun 14, 2024

Conversation

devinbinnie
Copy link
Member

@devinbinnie devinbinnie commented Jun 12, 2024

Summary

Found a few small issues in the repo that I wanted to fix:

  • Noticed the CI build wasn't running eslint, so I've added that and fixed up the ESLint issues that were outstanding
  • Ran npm audit fix to remove package vulnerabilities
NONE

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Jun 12, 2024
@devinbinnie devinbinnie changed the title Desktop fixes jun12 Assorted Desktop App repo fixes Jun 12, 2024
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jun 12, 2024
Copy link

Here are the test results below:

Test Summary for Linux on commit be35eb7

New failed tests found on Linux:

  • copylink MM-T125 Copy Link can be used from channel LHS

Test Summary for macOS on commit be35eb7

New failed tests found on macOS:

  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu_bar/dropdown MM-T4405 should set name of menu item from config file
  • menu_bar/dropdown MM-T4407 should open the new server prompt after clicking the add button

Test Summary for Windows on commit be35eb7

New failed tests found on Windows:

  • copylink MM-T125 Copy Link can be used from channel LHS

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jun 12, 2024
@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jun 14, 2024
Copy link

Here are the test results below:

Test Summary for Linux on commit 42b8f39

New failed tests found on Linux:

  • copylink MM-T125 Copy Link can be used from channel LHS

Test Summary for macOS on commit 42b8f39

New failed tests found on macOS:

  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu_bar/dropdown MM-T4405 should set name of menu item from config file
  • menu_bar/dropdown MM-T4407 should open the new server prompt after clicking the add button

Test Summary for Windows on commit 42b8f39

New failed tests found on Windows:

  • copylink MM-T125 Copy Link can be used from channel LHS

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Jun 14, 2024
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy link locator is changed. So we see the e2e failing. Nothing related to the PR is causing it.

@devinbinnie devinbinnie merged commit be182ac into master Jun 14, 2024
17 of 20 checks passed
@devinbinnie devinbinnie deleted the desktop_fixes_jun12 branch June 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants