Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec/oauth TOC Links Unresolvable #1139

Closed
dezren39 opened this issue Dec 31, 2022 · 2 comments · Fixed by #1110
Closed

spec/oauth TOC Links Unresolvable #1139

dezren39 opened this issue Dec 31, 2022 · 2 comments · Fixed by #1110

Comments

@dezren39
Copy link

https://docs.joinmastodon.org/spec/oauth/

In the TOC At the top,
The 3 Methods Listed don't link correctly.
I think this is because the chapter links are actually into the methods pages and whatever automation works on these links is confused by that. But I could be entirely wrong.
The other links in the TOC work OK.
The actual links if you scroll down in the page work fine.

[What is OAuth?](https://docs.joinmastodon.org/spec/oauth/#intro)
[OAuth 2 endpoints implemented](https://docs.joinmastodon.org/spec/oauth/#implementation)
[GET /oauth/authorize](https://docs.joinmastodon.org/spec/oauth/HAHAHUGOSHORTCODE-s4-HBHB)
[POST /oauth/token](https://docs.joinmastodon.org/spec/oauth/HAHAHUGOSHORTCODE-s5-HBHB)
[POST /oauth/revoke](https://docs.joinmastodon.org/spec/oauth/HAHAHUGOSHORTCODE-s6-HBHB)
[Common gotchas](https://docs.joinmastodon.org/spec/oauth/#gotchas)

Chrome v111

@trwnh
Copy link
Member

trwnh commented Dec 31, 2022

oh, it's because the headings are linked to a different section -- the {{< should be {{% to make them non-rendering shortcodes. Or perhaps it would be best to just reformat them so that the links are below the headers rather than inside them...

trwnh added a commit to trwnh/mastodocs that referenced this issue Dec 31, 2022
@trwnh
Copy link
Member

trwnh commented Dec 31, 2022

Should be fixed in #1110 now

Gargron pushed a commit that referenced this issue Feb 7, 2023
* Fix typos in method examples

* Fix broken link to sanitize_config (#1115)

* Add SIDEKIQ_CONCURRENCY

* Fix relref to FilterResult (#1114)

* Fix status_ids and rule_ids description (#1126)

* fix typo (#1129)

* clarify confusing example (mastodon/mastodon#22854)

* fix formatting on linked headings (#1139)

* fix placeholder entity names (#1157)

* better wording

* fix scheduledstatus#params.visibility

* fix missing: tootctl accounts modify --remove-role

* add: status/translate

* add deprecation/removal warning to microformats page

* clarify further how link verification works

* clarify mastodon requirements for webfinger

* fix: push param policy -> data[policy]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants