Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8902
A bunch of quality of life updates for the integration tests:
tape
so we get @ryanhamley 's patch that reports names of timed out tests (Include name of test in log when test times out tape-testing/tape#524)t.error(e)
. This accounts for any synchronously thrown errors.map
andcontainer
so next test can proceed smoothly.wait
operation now waits for atleast one frame to be rendered,map._render()
have also been removed and replaced with async wait-for-one-frame via a map event.I also discovered that a few tests were silently throwing errors, I've fixed them and updated their expected outputs.
Launch Checklist