Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser query-test runner doesnt report test timeouts and crashed tests correctly #8902

Closed
arindam1993 opened this issue Oct 24, 2019 · 1 comment · Fixed by #10351
Closed
Assignees
Labels

Comments

@arindam1993
Copy link
Contributor

Discovered by @ryanhamley, this is two issues that are related. If a test crashes, the exception gets silently caught by the test runner and the callstack exits causing t.end() to never be called, resulting in the test timing out.

The code that generates the visualization then crashes as its unable to parse the timeout metaData correctly.

@asheemmamoowala
Copy link
Contributor

Addressed by #10351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants