Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change window access modifier to open #46

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Change window access modifier to open #46

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
311e0d1
Make window open.
julianrex Sep 1, 2023
934b02a
Calm compiler
julianrex Sep 1, 2023
ce4d903
Remove unused code, support additional touch type
julianrex Sep 1, 2023
2c5451f
Remove duplicates
julianrex Sep 1, 2023
6e89f5c
Revert region handling
julianrex Sep 1, 2023
aca10de
Oops
julianrex Sep 1, 2023
f12793f
Remove rootViewController shenanigans
julianrex Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert region handling
  • Loading branch information
@julianrex
julianrex committed Sep 1, 2023
commit 6e89f5c636e04bc1118c7d923c8aa6eca7dd104b
5 changes: 3 additions & 2 deletions Sources/Fingertips/FingerTipWindow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ open class FingerTipWindow: UIWindow {

for touch in allTouches {
switch touch.phase {
case .began, .moved, .stationary, .regionEntered, .regionMoved:
case .began, .moved, .stationary:
var touchView = overlayWindow.viewWithTag(touch.hashValue) as? FingerTipView

if touch.phase != .stationary && touchView != nil && touchView?.fadingOut == true {
Expand All @@ -184,9 +184,10 @@ open class FingerTipWindow: UIWindow {
touchView?.shouldAutomaticallyRemoveAfterTimeout = shouldAutomaticallyRemoveFingerTip(for: touch)
}
break
case .ended, .cancelled, .regionExited:
case .ended, .cancelled:
removeFingerTip(with: touch.hashValue, animated: true)
break
case .regionEntered, .regionMoved, .regionExited:
@unknown default:
break
}
Expand Down