Change window access modifier to open #46
Conversation
| func cancelScheduledFingerTipRemoval() { | ||
| fingerTipRemovalScheduled = true | ||
| NSObject.cancelPreviousPerformRequests(withTarget: self, | ||
| selector: #selector(removeInactiveFingerTips), | ||
| object: nil) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not used; I imagine that it was once used in conjunction with the perform(#selector(removeInactiveFingerTips), with: nil, afterDelay: 0.1). I do not see a need for it, but perhaps I'm not seeing the full picture.
| @@ -233,16 +228,27 @@ public class FingerTipWindow: UIWindow { | |||
| return | |||
| } | |||
|
|
|||
| UIView.animate(withDuration: fadeDuration) { | |||
| let animation = { | |||
There was a problem hiding this comment.
The animated parameter wasn't being observed. As it is it seems that animated is always true, so we could simplify and rename to removeFingerTipAnimated(with:).
|
This causes the following warning in the console: Edit: Making the changes in f12793f removes this warning. |
| class FingerTipOverlayWindow: UIWindow { | ||
| override var rootViewController: UIViewController? { | ||
| set { | ||
| super.rootViewController = newValue | ||
| } | ||
|
|
||
| get { | ||
| return FingerTipWindow.fingerTipWindow?.rootViewController ?? super.rootViewController | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This was causing a warning in logs; the getter also looks suspicious - sharing a view controller between UIWindows sounds dangerous. I don't see any issue with removing this code.
Hello friends 馃槃
Small PR to change the window to open, along with a few other changes noted as comments.
Tested manually in an iPadOS application.
/cc @OdNairy