React native unit tests #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithki
force-pushed
the
react_native_unit_tests
branch
from
6e83941
to
35bb791
Compare
smithki
force-pushed
the
react_native_unit_tests
branch
from
365b304
to
e057904
Compare
smithki
force-pushed
the
react_native_unit_tests
branch
from
9e0ba0c
to
4cb28e8
Compare
smithki
added a commit
that referenced
this pull request
Apr 22, 2020
* Update build system to support a React Native bundle * Add initial implementation for React Native (requires e2e testing) * Fix CJS builds and rename 'WebViewController' to 'ReactNativeWebViewController' * Remove unnecessary return statement * Fix React dependency regex in Webpack config * Update CircleCI config * Re-organize '/core' tests to reflect additional view controllers * Organizational comments * Remove superfluous comment * Add first draft CHANGELOG entry for React Native feature * Update 'isViewReady' condition * Package 'react-native-webview' and 'whatwg-url' in the RN bundle * Add .vscode to git ignores * Add /dist to eslint ignores * Clean up Webpack config * Externalize 'react-native-webview' & fix event listener bug in 'PayloadTransport' * React native unit tests (#49) * Add constructor test for MagicSDKReactNative * Add 'magic.link' as homepage in 'package.json' * Update 'tsconfig.jsx' to 'react-native' * Revert change to tsconfig * Fix test preprocessing to support React/React Native * Fix typo * Fix 'PayloadTransport.post' tests * Cleanup test files & improve core SDK coverage after RN changes * Add unit tests for 'PayloadTransport.handleReactNativeWebViewMessage' * Update architectural overview with React Native-specific info * Add unit tests for 'ReactNativeWebViewController' methods (WIP) * Add coverage ignore comment * Add 'utils/url' tests * Add some testing cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Adds unit testing related to #37
🗜 Versioning
(Check one!)
✅ Fixed Issues
🚨 Test instructions
Run
yarn test😄CHANGELOG.mdUpcoming Changessection ofCHANGELOG.mdwith context related to this Pull Request.