Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React Native #37

Merged
merged 21 commits into from
Apr 22, 2020
Merged

Support React Native #37

merged 21 commits into from
Apr 22, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Apr 10, 2020 •
edited

📦 Pull Request

Adds support for React Native

🗜 Versioning

(Check one!)

  • Patch: Bug Fix?
  • Minor: New Feature?
  • Major: Breaking Change?

✅ Fixed Issues

🚨 Test instructions

yarn test as usual 😄

⚠️ Update CHANGELOG.md

  • I have updated the Upcoming Changes section of CHANGELOG.md with context related to this Pull Request.

@smithki smithki self-assigned this Apr 11, 2020
@smithki
Update build system to support a React Native bundle
544e411
@smithki
Add initial implementation for React Native (requires e2e testing)
cecf18f
@smithki
Fix CJS builds and rename 'WebViewController' to 'ReactNativeWebViewC…
40d5e2c 
…ontroller'
@smithki
Remove unnecessary return statement
60c926f
@smithki
Fix React dependency regex in Webpack config
063b820
@smithki
Update CircleCI config
9e7e68d
@smithki
Re-organize '/core' tests to reflect additional view controllers
ac50c28
@smithki
Organizational comments
93e2657
@smithki
Remove superfluous comment
d2e2021
@smithki
Add first draft CHANGELOG entry for React Native feature
73e6c53
@smithki
Update 'isViewReady' condition
e6a1957
@smithki
Package 'react-native-webview' and 'whatwg-url' in the RN bundle
768dc7b
@smithki
Add .vscode to git ignores
1abad60
@smithki
Add /dist to eslint ignores
337e6c3
@smithki
Clean up Webpack config
c62a6a6
@smithki
Externalize 'react-native-webview' & fix event listener bug in 'Paylo…
520e510 
…adTransport'
@Ethella Ethella self-requested a review April 15, 2020 23:11
@Ethella
Copy link
Member

Ethella commented Apr 15, 2020

image

Approve that it's been well tested on IOS RN.
Will test in Android RN

Also waiting for https://github.com/fortmatic/mgbox/pull/14 to be merged

@smithki smithki mentioned this pull request Apr 18, 2020
Merged
4 tasks
@smithki smithki marked this pull request as ready for review April 22, 2020 05:40
@smithki
React native unit tests (#49)
849d1b0 
* Add constructor test for MagicSDKReactNative

* Add 'magic.link' as homepage in 'package.json'

* Update 'tsconfig.jsx' to 'react-native'

* Revert change to tsconfig

* Fix test preprocessing to support React/React Native

* Fix typo

* Fix 'PayloadTransport.post' tests

* Cleanup test files & improve core SDK coverage after RN changes

* Add unit tests for 'PayloadTransport.handleReactNativeWebViewMessage'

* Update architectural overview with React Native-specific info

* Add unit tests for 'ReactNativeWebViewController' methods (WIP)

* Add coverage ignore comment

* Add 'utils/url' tests
@smithki smithki changed the title Support React Native (W.I.P.) Support React Native Apr 22, 2020
@smithki
Copy link
Contributor Author

smithki commented Apr 22, 2020

@Ethella -- Thanks for all your help testing/verifying this, do I have your blessing to merge & release?

@FYJen -- Once the snyk failure is checked on, I'm comfortable releasing this and open-sourcing the repo! 🚀

Ethella
Ethella approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheep

@smithki smithki merged commit 24228c3 into master Apr 22, 2020
@smithki smithki deleted the react_native branch April 22, 2020 19:50
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 PR was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

Assignees

@smithki smithki

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
04/20 - 04/27: Quarantine continues 😷
Development

Successfully merging this pull request may close these issues.

Support React Native
3 participants
@smithki @Ethella @FYJen