Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: fix arrow variant for 32-bit #24690

Closed
wants to merge 1 commit into from

Conversation

barracuda156
Copy link
Contributor

Description

No revbump needed here. It would simply not build with this variant otherwise.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@nilason for port gdal.
@Veence for port gdal.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Jun 26, 2024
@nilason
Copy link
Contributor

nilason commented Jun 26, 2024

I can’t test this, I trust you on this.

@barracuda156
Copy link
Contributor Author

I can’t test this, I trust you on this.

Yes, I have built it successfully after adding the fix, of course.

Dave-Allured added a commit to Dave-Allured/macports-ports that referenced this pull request Jun 26, 2024
* Update gdal 3.9.0 --> 3.9.1.
* Merge in two other gdal pull requests.
* Fix arrow variant for 32-bit.  See PR macports#24690.
* Do not opportunistically link to armadillo.  See PR macports#24687.

Fixes: https://trac.macports.org/ticket/70298
@Dave-Allured Dave-Allured mentioned this pull request Jun 27, 2024
9 tasks
@Dave-Allured
Copy link
Contributor

@barracuda156 for expediency I merged your arrow 32 bit changes into my new update PR #24695. Okay with you? Please review that new PR.

@barracuda156
Copy link
Contributor Author

Closing in favor of #24695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
5 participants