Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal: prepare to migrate driver variants to subports; add gdal-pdf and gdal-libkml #24660

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jun 24, 2024

Description

  • Prepare Portfile to migrate gdal driver variants to subports
  • new gdal-pdf port
  • new gdal-libkml port
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.5 23F79 arm64
Xcode 15.4 15F31d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Veence for port gdal.

@macportsbot macportsbot added maintainer maintainer: open Affects an openmaintainer port labels Jun 24, 2024
@nilason nilason marked this pull request as draft June 24, 2024 11:11
@nilason nilason force-pushed the gdal-subports branch 2 times, most recently from bbb1ad2 to f5ac076 Compare June 25, 2024 14:42
@barracuda156
Copy link
Contributor

@nilason Could we also fix this one? https://trac.macports.org/ticket/70295

@Dave-Allured
Copy link
Contributor

There are now four open PR's for GDAL. Upstream just announced version 3.9.1, which includes significant compile fixes and plugin changes. I submitted #24691 for the update.

Because of the plugin changes, I recommend further subport efforts should work off of 3.9.1 rather than 3.9.0. If it makes it easier to merge the 3.9.1 update into this or any other PR, that is fine with me. I would cancel #24691 in that case. I am glad others are working hard to improve the GDAL port.

@nilason
Copy link
Contributor Author

nilason commented Jun 26, 2024

For the rest of this week I can’t work on this, the update is good though (I tested the RC2).

@barracuda156
Copy link
Contributor

barracuda156 commented Jun 27, 2024

@nilason Now since the update is killed, we should ensure to borrow a commit with a fix for Arrow variant from there.

UPD. And more importantly, armadillo issue fix.

@Dave-Allured Dave-Allured mentioned this pull request Jun 27, 2024
9 tasks
@Dave-Allured
Copy link
Contributor

Update to 3.9.1 is now in process on new PR #24707. Armadillo fix is included.

Arrow/libatomic fix is NOT included and must be independent. See followup discussion on #24690, #24695.

@barracuda156
Copy link
Contributor

Arrow/libatomic will be done separately, and it will not require any revbumping, so it can be merged to whichever version GDAL has at the moment.

@Dave-Allured Dave-Allured mentioned this pull request Jun 28, 2024
9 tasks
@nilason nilason marked this pull request as ready for review July 1, 2024 09:56
@nilason
Copy link
Contributor Author

nilason commented Jul 1, 2024

Added a change of libkml's boost dependency type to PG default (lib), which was necessary to enable build of gdal-libkml.

This is now ready for review.

@pmetzger
Copy link
Member

pmetzger commented Jul 8, 2024

What should be done with this at this point? Should it be committed?

@nilason
Copy link
Contributor Author

nilason commented Jul 9, 2024

What should be done with this at this point? Should it be committed?

From my side this is ready for merge, please go ahead.

@pmetzger pmetzger merged commit b2f3fe6 into macports:master Jul 9, 2024
3 checks passed
@nilason nilason deleted the gdal-subports branch July 9, 2024 14:28
@barracuda156
Copy link
Contributor

@nilason There is a problem with libkml now due to a conflict of minizip port and its bundled copy also used by the build: https://trac.macports.org/ticket/70349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port maintainer
Development

Successfully merging this pull request may close these issues.

6 participants