ibnetdisc: Fix leak in add_to_portlid_hash #1409
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the duplicate port is added to the map cl_qmap_insert() returns pointer to existing value and the new entry is left unused that results in leak: ==1606814== 2,624 bytes in 41 blocks are definitely lost in loss record 1 of 1 ==1606814== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==1606814== by 0x5174B59: add_to_portlid_hash (ibnetdisc.c:704) ==1606814== by 0x517638E: recv_port_info (ibnetdisc.c:379) ==1606814== by 0x51789B0: process_one_recv (query_smp.c:200) ==1606814== by 0x5178EF7: process_mads (query_smp.c:276) ==1606814== by 0x51755E7: ibnd_discover_fabric (ibnetdisc.c:817) ==1606814== by 0x109229: main (in /vagrant/go/gpu/ib-ict-manager/a.out) The solution is to free new item if it was not added to the map. Fixes: 1616816 ("ibdiags: Use cl_qmap instead of glib hashtable") Signed-off-by: Anton Kuchin <[email protected]>
aikuchin
force-pushed
the
fix_leak_in_add_to_portlid_hash
branch
2 times, most recently
from
9ce8974
to
5814d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the duplicate port is added to the map cl_qmap_insert() returns pointer to existing value and the new entry is left unused that results in leak:
==1606814== 2,624 bytes in 41 blocks are definitely lost in loss record 1 of 1
==1606814== at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==1606814== by 0x5174B59: add_to_portlid_hash (ibnetdisc.c:704)
==1606814== by 0x517638E: recv_port_info (ibnetdisc.c:379)
==1606814== by 0x51789B0: process_one_recv (query_smp.c:200)
==1606814== by 0x5178EF7: process_mads (query_smp.c:276)
==1606814== by 0x51755E7: ibnd_discover_fabric (ibnetdisc.c:817)
==1606814== by 0x109229: main (in /vagrant/go/gpu/ib-ict-manager/a.out)
The solution is to free new item if it was not added to the map.
Fixes: 1616816 ("ibdiags: Use cl_qmap instead of glib hashtable")
UPD: Fixed format of "Fixes" tag, the only problem reported by CI is a long line in valgrind output, but I think it is better to keep it that way than wrap the line.