Merge pull request #1409 from aikuchin/fix_leak_in_add_to_portlid_hash

ibnetdisc: Fix leak in add_to_portlid_hash
linux-rdma · Dec 17, 2023 · 482b7fb · 482b7fb
2 parents 69cc13f + 5814d78
commit 482b7fb
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/libibnetdisc/ibnetdisc.c b/libibnetdisc/ibnetdisc.c
@@ -704,8 +704,11 @@ void add_to_portlid_hash(ibnd_port_t * port, f_internal_t *f_int)
  item = malloc(sizeof(*item));
  if (item) {
  item->port = port;
- cl_qmap_insert(&f_int->lid2guid, lid,
- &item->cl_map);
+ if (cl_qmap_insert(&f_int->lid2guid, lid,
+ &item->cl_map) != &item->cl_map) {
+ /* Port is already in map, release item */
+ free(item);
+ }
  }
  }
  }