Fix request ID handling in HttpTraceInitializer #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! 👍 ⭐ |
|
sweet 👍 🔋 |
| val id = id0.sampled match { | ||
| case Some(s) => id0 | ||
| case None => id0.copy(_sampled = tracer.sampleTrace(id0)) | ||
| def sample[T](sampler: Option[Sampler])(f: => T) = { |
There was a problem hiding this comment.
nit: omit needless braces (the def doesn't need its own braces since everything is in the sampler match
|
👍 |
| Trace.letTracerAndNextId(tracer) { | ||
| sample(sampler) { | ||
| service(req) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
tioli: this block may warrant a small comment about the ordering of things. e.g.
// 1. Set the trace id from the header, if one was provided
// 2. Get a new trace Id for this request.
// 3. Use the sample header to determine if tracing should be forced.
|
very nice! thanks for taking time to dig into this. ⭐ |
|
Addressed @olix0r's feedback and rebased. ⭐ |
|
⭐ |
Fixing a few issues related to request IDs: * New traces are now assigned a unique root request ID * New incoming server requests for existing traces are assigned a unique span ID * Added more extensive tests for request ID handling
|
⭐ rebased (again) |
klingerf
added a commit
that referenced
this pull request
Feb 10, 2016
Fix request ID handling in HttpTraceInitializer
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this pull request
Dec 20, 2018
* Make TabbedMetricsTable in charge of fetching timeseries All of the parent components in charge of fetching timeseries data don't actually use them, but pass them to this table. It would simplify a lot of the parents if this component handled the ts fetching too. This introduces a urlsForResource helper in ApiHelpers to allow us to consolidate url generating in the app to one place. It also associates the appropriate groupBy for various fetches. Signed-off-by: Risha Mars <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some general cleanup related to how request IDs are handled, as follows: