-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L5D-Sample header is checked against static value #80
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The L5D-Sample header should allow you to specify a sample rate, such that a corresponding percentage of requests with that header are sampled. For instance, if I set
L5D-Sample: 0.2
on 100 requests, I'd expect roughly 20 requests to be sampled.Instead, it looks like the value of that header is being checked against a float value that remains constant for the lifetime of the linkerd process. For instance, if the threshold that's determined when linkerd starts is 0.35, 0% of requests with the
L5D-Sample: 0.3
header will be sampled, and 100% of requests with theL5D-Sample: 0.4
header will be sampled. When the process restarts it picks up a new threshold at random.The text was updated successfully, but these errors were encountered: