Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate trace annotations when L5D-Sample header set #79

Closed
klingerf opened this issue Feb 9, 2016 · 0 comments · Fixed by #89
Closed

Duplicate trace annotations when L5D-Sample header set #79

klingerf opened this issue Feb 9, 2016 · 0 comments · Fixed by #89
Assignees

Comments

@klingerf
Copy link
Member

klingerf commented Feb 9, 2016

I've running linkerd with an http router configured to route requests received on port 4140 to a "web" service running on port 7000. When I make a request with the L5D-Sample: 1 header set, I see duplicate trace annotations as follows:

$ curl -H 'Host: web' -H 'L5d-sample: 1' http:https://127.1:4140/ping
...
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 ServiceName(0.0.0.0/4140)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(srv/finagle.version,6.31.0)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 ServerRecv()
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 LocalAddr(/127.0.0.1:4140)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 ServerAddr(/127.0.0.1:4140)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 ClientAddr(/127.0.0.1:49600)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(namer.dtab.base,/status=>/$/io.l5d.http.status;/www=>/host/web;/host=>/$/io.buoyant.http.anyHostPfx/www;/host=>/io.l5d.fs;/method=>/$/io.buoyant.http.anyMethodPfx/host;/http/1.1=>/method)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(namer.dtab.local,)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(namer.path,/http/1.1/GET/web)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 Message(namer.success)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ServiceName(io.l5d.fs/web)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(dst.id,/io.l5d.fs/web)
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 BinaryAnnotation(dst.path,/)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ServiceName(io.l5d.fs/web)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(clnt/finagle.version,6.31.0)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(clnt/finagle.version,6.31.0)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientSend()
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientSend()
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.method,GET)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.method,GET)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.uri,/ping)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.uri,/ping)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.host,web)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.host,web)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.version,HTTP/1.1)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.version,HTTP/1.1)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 WireSend
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 WireSend
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ServerAddr(/127.0.0.1:7000)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ServerAddr(/127.0.0.1:7000)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientAddr(/127.0.0.1:49588)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientAddr(/127.0.0.1:49588)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 WireRecv
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 WireRecv
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.status,200)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.status,200)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.version,HTTP/1.1)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.version,HTTP/1.1)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.content-length,4)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.content-length,4)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.content-type,text/plain)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 BinaryAnnotation(http.content-type,text/plain)
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientRecv()
bc2f33bcda4be209.fcca4401059c9b52<:bc2f33bcda4be209 ClientRecv()
bc2f33bcda4be209.bc2f33bcda4be209<:bc2f33bcda4be209 ServerSend()
@klingerf klingerf self-assigned this Feb 9, 2016
@olix0r olix0r added the ready label Feb 9, 2016
@klingerf klingerf added reviewable and removed ready labels Feb 10, 2016
Tim-Brooks pushed a commit to Tim-Brooks/linkerd that referenced this issue Dec 20, 2018
Previously Conduit would render an iframe, received from
versioncheck.conduit.io.

Modify the client to retrieve the latest released version, via CORS.

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants