[LI-CHERRY-PICK] [e4215c1] KAFKA-8325, KAFKA-8202; Remove batch from in-flight requests on MESSAGE_TOO_LARGE errors (#7176) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-flight requests on MESSAGE_TOO_LARGE errors (apache#7176) TICKET = KAFKA-8052, KAFKA-8202 LI_DESCRIPTION = This patch fixes memory leaks in producer when batch split happens. EXIT_CRITERIA = HASH [e4215c1] ORIGINAL_DESCRIPTION = This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests. Reviewers: Luke Stephenson, Ismael Juma <[email protected]>, Jason Gustafson <[email protected]>
a110124
to
6bfd49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET = KAFKA-8052, KAFKA-8202
LI_DESCRIPTION =
This patch fixes memory leaks in producer when batch split happens.
EXIT_CRITERIA = HASH [e4215c1]
ORIGINAL_DESCRIPTION =
This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests.
Reviewers: Luke Stephenson, Ismael Juma [email protected], Jason Gustafson [email protected]