KAFKA-8325: Remove batch from in-flight requests when handling MESSAG… #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_TOO_LARGE error This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests.
ijuma
reviewed
Aug 10, 2019
| @@ -625,6 +625,7 @@ private void completeBatch(ProducerBatch batch, ProduceResponse.PartitionRespons | |||
| if (transactionManager != null) | |||
| transactionManager.removeInFlightBatch(batch); | |||
| this.accumulator.splitAndReenqueue(batch); | |||
| maybeRemoveFromInflightBatches(batch); | |||
| this.accumulator.deallocate(batch); | |||
There was a problem hiding this comment.
Would it make sense to have a method that deallocates and removes from in flight batches?
There was a problem hiding this comment.
Yeah, I think that's reasonable. Added.
ijuma
approved these changes
Aug 15, 2019
| client.prepareResponse(new AddPartitionsToTxnResponse(0, Collections.singletonMap(tp0, Errors.NONE))); | ||
| sender.runOnce(); | ||
|
|
||
| // create a producer batch with more than one record so it is eligible to split |
There was a problem hiding this comment.
Nit: eligible for splitting?
| accumulator.append(tp0, time.milliseconds(), "key2".getBytes(), "value2".getBytes(), null, null, | ||
| MAX_BLOCK_TIMEOUT, false).future; | ||
|
|
||
| sender.runOnce(); // send request |
There was a problem hiding this comment.
Should this comment be before the method for consistency with other comments?
|
retest this please |
hachikuji
pushed a commit
that referenced
this pull request
Aug 22, 2019
… errors (#7176) This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests. Reviewers: Luke Stephenson, Ismael Juma <[email protected]>, Jason Gustafson <[email protected]>
hzxa21
pushed a commit
to hzxa21/kafka
that referenced
this pull request
Aug 22, 2019
…in-flight requests on MESSAGE_TOO_LARGE errors (apache#7176) TICKET = KAFKA-8052, KAFKA-8202 LI_DESCRIPTION = This patch fixes memory leaks in producer when batch split happens. EXIT_CRITERIA = HASH [e4215c1] ORIGINAL_DESCRIPTION = This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests. Reviewers: Luke Stephenson, Ismael Juma <[email protected]>, Jason Gustafson <[email protected]>
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 27, 2019
…quests on MESSAGE_TOO_LARGE errors (apache#7176) TICKET = KAFKA-8325 LI_DESCRIPTION = EXIT_CRITERIA = HASH [db8cb96] ORIGINAL_DESCRIPTION = This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests. Reviewers: Luke Stephenson, Ismael Juma <[email protected]>, Jason Gustafson <[email protected]> (cherry picked from commit db8cb96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…E_TOO_LARGE error
This patch fixes a bug in the handling of MESSAGE_TOO_LARGE errors. The large batch is split, the smaller batches are re-added to the accumulator, and the batch is deallocated, but it was not removed from the list of in-flight batches. When the batch was eventually expired from the in-flight batches, the producer would try to deallocate it a second time, causing an error. This patch changes the behavior to correctly remove the batch from the list of in-flight requests.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)