Use debug level logging to avoid performance impact (#23) #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Resolves #23 by logging debug logs at an appropriate logging level to make server less busy for logging during high traffic rate.
Overview or reasons
It appears that current logs in the FIDO server are mainly for debugging purpose, but they are logged in info level.
As a result, even if info level is configured in logback, they are always logged. When traffic rate is high, the server becomes busy for logging.
On the other hand, some logs passes parameters with manual string construction instead of {} placeholder, so the impact is even larger. (See https://www.slf4j.org/faq.html#logging_performance for details)
Tasks
debug
level:log.info
->log.debug
{}
placeholders in log message whenever possibletoString
orString.format
. This can avoid redundant computation when the log is not required for the configured log level.Result
debug
level.