Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inappropriate logging level affects performance on high traffic #23

Closed
ericlai616 opened this issue Apr 27, 2022 · 0 comments · Fixed by #24
Closed

Inappropriate logging level affects performance on high traffic #23

ericlai616 opened this issue Apr 27, 2022 · 0 comments · Fixed by #24

Comments

@ericlai616
Copy link
Contributor

It appears that current logs in the FIDO server are mainly for debugging purpose, but they are logged in info level.

As a result, even if info level is configured in logback, they are always logged. When traffic rate is high, the server becomes busy for logging.

On the other hand, some logs passes parameters with manual string construction instead of {} placeholder, so the impact is even larger. (See https://www.slf4j.org/faq.html#logging_performance for details)
ericlai616 pushed a commit to ericlai616/line-fido2-server that referenced this issue Apr 27, 2022
Use debug level logging to avoid performance impact (line#23)
f9b2977
ericlai616 pushed a commit to ericlai616/line-fido2-server that referenced this issue Apr 27, 2022
Use debug level logging to avoid performance impact (line#23)
26a21f2
@ericlai616 ericlai616 mentioned this issue Apr 27, 2022
Merged
ericlai616 added a commit to ericlai616/line-fido2-server that referenced this issue Apr 27, 2022
@ericlai616
Use debug level logging to avoid performance impact (line#23)
f6d9f59
kj84park pushed a commit that referenced this issue Apr 28, 2022
@ericlai616
Use debug level logging to avoid performance impact (#23) (#24)
7ad6e86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use debug level logging to avoid performance impact (#23) ericlai616/line-fido2-server
1 participant
@ericlai616