Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the Lightstep Metrics SDK #196

Merged
merged 87 commits into from
Jun 28, 2022
Merged

Merge the Lightstep Metrics SDK #196

merged 87 commits into from
Jun 28, 2022

Conversation

jmacd
Copy link
Member

@jmacd jmacd commented Jun 24, 2022

Description: This merges the work covered in PRs:

#171
#172
#173
#174
#175
#183
#184
#185
#190
#191
#195

Link to tracking Issue: LS-29760

Testing: The SDK is completely unit-tested. Manual integration testing with lightstep has been done.

Thanks: Thanks to @MadVikingGod for substantial early feedback on the design of the Lightstep metrics SDK. Thanks to @jaronoff97 @njvrzm @paivagustavo @codeboten for reivews.

jmacd and others added 30 commits May 23, 2022 07:18
Add the internal/viewstate package for review LS-29753
…launcher-go into alt_metrics_sdk/provider_review
Add the MeterProvider and related packages for review LS-29752
…launcher-go into alt_metrics_sdk/review_internalstate
❤️

Co-authored-by: Nathan Vērzemnieks <[email protected]>
@jmacd jmacd requested a review from codeboten June 24, 2022 16:44
@jmacd
Copy link
Member Author

jmacd commented Jun 24, 2022

I am officially stuck (from my machine):

ERRO Running error: 1 error occurred:
	* can't run linter goanalysis_metalinter: failed to pre-run gofmt: failed to validate analyzers: analyzer "gofmt" has nil Run

or (from CI)_

level=warning msg="[runner] Can't run linter goanalysis_metalinter: failed to pre-run errcheck: failed to validate analyzers: analyzer \"errcheck\" has nil Run"

@jmacd
Copy link
Member Author

jmacd commented Jun 28, 2022

After disabling the linters, I've found some flakey test failures.

@codecov-commenter
Copy link

Codecov Report

Merging #196 (d2d4b8f) into main (d233da9) will increase coverage by 3.92%.
The diff coverage is 95.14%.

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   90.72%   94.65%   +3.92%     
==========================================
  Files           7       62      +55     
  Lines         485     3234    +2749     
==========================================
+ Hits          440     3061    +2621     
- Misses         26      131     +105     
- Partials       19       42      +23     
Impacted Files Coverage Δ
pipelines/common.go 100.00% <ø> (ø)
...k/metric/exporters/otlp/internal/otlpconfig/tls.go 41.66% <41.66%> (ø)
...k/metric/aggregator/aggregation/category_string.go 50.00% <50.00%> (ø)
lightstep/sdk/metric/number/kind_string.go 50.00% <50.00%> (ø)
lightstep/sdk/metric/sdkinstrument/kind_string.go 50.00% <50.00%> (ø)
...p/sdk/metric/aggregator/aggregation/temporality.go 55.55% <55.55%> (ø)
pipelines/metrics.go 67.18% <65.21%> (-13.31%) ⬇️
lightstep/sdk/metric/exporters/otlp/exporter.go 67.34% <67.34%> (ø)
...etric/aggregator/aggregation/temporality_string.go 75.00% <75.00%> (ø)
...tric/exporters/otlp/internal/otlpconfig/options.go 82.20% <82.20%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d233da9...d2d4b8f. Read the comment docs.

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo very excited!! Thank you so much!

@jmacd jmacd merged commit 6691b6b into main Jun 28, 2022
@jmacd jmacd deleted the alt_metrics_sdk/reviewed branch June 28, 2022 18:25
@jmacd jmacd restored the alt_metrics_sdk/reviewed branch June 28, 2022 18:26
@jmacd jmacd deleted the alt_metrics_sdk/reviewed branch August 4, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants